Remove LibraryEntity.libraryName

pkg/compiler/lib/src/elements/modelx.dart

Index: pkg/compiler/lib/src/elements/modelx.dart
diff --git a/pkg/compiler/lib/src/elements/modelx.dart b/pkg/compiler/lib/src/elements/modelx.dart
index 6ff57cc0812853b7b839771819081f406764dea4..e0bdb6f01839b20296961f03b3142a73b3a49a75 100644
--- a/pkg/compiler/lib/src/elements/modelx.dart
+++ b/pkg/compiler/lib/src/elements/modelx.dart
@@ -1217,6 +1217,8 @@ class LibraryElementX extends ElementX
     });
   }
 
+  String get name => hasLibraryName ? libraryName : super.name;

[Siggi Cherem (dart-lang), 2017/01/13 16:51:18]

I'm not sure I follow why we also need to change `name`. There are a few places
where we use `library.name` and it's not clear to me if we were assuming that it
defaults to script.name.

If we do this change, do we need libraryOrScriptName anymore?

[Johnni Winther, 2017/01/16 10:07:38]

[name] is available on Entity but for a library it has no inherent semantics
since libraries are not referenced by name. Therefore we can use it as a (more
informal) discriminator.

It does seem to make [libraryOrScriptName] superfluous.

+
   bool get hasLibraryName => libraryTag != null;
 
   String get libraryName {