Remove LibraryEntity.libraryName

pkg/compiler/lib/src/elements/modelx.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library elements.modelx;
 
 import '../common.dart';
 import '../common/names.dart' show Identifiers;
 import '../common/resolution.dart' show Resolution, ParsingContext;
 import '../compiler.dart' show Compiler;
@@ skipping 1199 matching lines @@
   }
 
   Iterable<Element> getNonPrivateElementsInScope() {
     return localScope.values.where((Element element) {
       // At this point [localScope] only contains members so we don't need
       // to check for foreign or prefix elements.
       return !Name.isPrivateName(element.name);
     });
   }
 
+  String get name => hasLibraryName ? libraryName : super.name;

[Siggi Cherem (dart-lang), 2017/01/13 16:51:18]

I'm not sure I follow why we also need to change `name`. There are a few places
where we use `library.name` and it's not clear to me if we were assuming that it
defaults to script.name.

If we do this change, do we need libraryOrScriptName anymore?

[Johnni Winther, 2017/01/16 10:07:38]

[name] is available on Entity but for a library it has no inherent semantics
since libraries are not referenced by name. Therefore we can use it as a (more
informal) discriminator.

It does seem to make [libraryOrScriptName] superfluous.

+
   bool get hasLibraryName => libraryTag != null;
 
   String get libraryName {
     if (libraryTag == null) return '';
     return libraryTag.name.toString();
   }
 
   String get libraryOrScriptName {
     if (libraryTag != null) {
       return libraryTag.name.toString();
@@ skipping 2191 matching lines @@
       body = node.asFunctionExpression().body;
     }
     return new ParsedResolvedAst(
         declaration,
         node,
         body,
         definingElement.treeElements,
         definingElement.compilationUnit.script.resourceUri);
   }
 }