third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp - Issue 2632633006: Implement NavigationThrottle::BLOCK_REQUEST_AND_COLLAPSE.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp

Issue 2632633006: Implement NavigationThrottle::BLOCK_REQUEST_AND_COLLAPSE. (Closed)

Patch Set: Extend tests, fix redirects. Non-PlzNavigate version still broken. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp

diff --git a/third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp b/third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp

index 3cb385991a22641af04526cd8fc0445b91c6569b..27ade9c7dc1f5894422eb4ac02717643b061c1ae 100644

--- a/third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp

+++ b/third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp

@@ -136,6 +136,11 @@ bool WebRemoteFrameImpl::hasVerticalScrollbar() const {

return false;

}

+void WebRemoteFrameImpl::collapse(bool collapsed) {

+ DCHECK(frame()->owner()->isLocal());

+ frame()->owner()->setCollapsedByClient(collapsed);

WebView* WebRemoteFrameImpl::view() const {

if (!frame())

return nullptr;