third_party/WebKit/Source/web/RemoteFrameOwner.cpp - Issue 2632633006: Implement NavigationThrottle::BLOCK_REQUEST_AND_COLLAPSE.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/RemoteFrameOwner.cpp

Issue 2632633006: Implement NavigationThrottle::BLOCK_REQUEST_AND_COLLAPSE. (Closed)

Patch Set: Extend tests, fix redirects. Non-PlzNavigate version still broken. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/RemoteFrameOwner.cpp

diff --git a/third_party/WebKit/Source/web/RemoteFrameOwner.cpp b/third_party/WebKit/Source/web/RemoteFrameOwner.cpp

index 8cb4c3ae54e46c34154dfc2ad76c331b5d46c6c9..6d0af28bd84ae584e46dcb231bc28f11ee9a1d99 100644

--- a/third_party/WebKit/Source/web/RemoteFrameOwner.cpp

+++ b/third_party/WebKit/Source/web/RemoteFrameOwner.cpp

@@ -34,6 +34,11 @@ void RemoteFrameOwner::setScrollingMode(

m_scrolling = static_cast<ScrollbarMode>(mode);

}

+void RemoteFrameOwner::setCollapsedByClient(bool collapsed) {

+ // Always set by the browser through FrameOwnerProperties.

dcheng 2017/02/28 05:36:22 Since this is a local-only method, it should only

engedy 2017/04/10 14:36:42 Done.

+ NOTREACHED();

void RemoteFrameOwner::setContentFrame(Frame& frame) {

m_frame = &frame;

}