third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.cpp - Issue 2632633006: Implement NavigationThrottle::BLOCK_REQUEST_AND_COLLAPSE.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.cpp

Issue 2632633006: Implement NavigationThrottle::BLOCK_REQUEST_AND_COLLAPSE. (Closed)

Patch Set: Extend tests, fix redirects. Non-PlzNavigate version still broken. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.cpp b/third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.cpp

index 64a0f46f576167b5defd7685ef767f4dbece0894..ec1dc52aa4eaa1d8ab96067ef75a3e5967390e97 100644

--- a/third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.cpp

@@ -157,6 +157,7 @@ void HTMLFrameOwnerElement::setContentFrame(Frame& frame) {

DCHECK(!m_contentFrame || m_contentFrame->owner() != this);

// Disconnected frames should not be allowed to load.

DCHECK(isConnected());

m_contentFrame = &frame;

for (ContainerNode* node = this; node; node = node->parentOrShadowHostNode())