Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(421)

Issue 2632633004: Ignore invalid optional constraints with invalid aspect ratio. (Closed)

Created:
3 years, 11 months ago by Guido Urdaneta
Modified:
3 years, 11 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, imcheng+watch_chromium.org, feature-media-reviews_chromium.org, posciak+watch_chromium.org, chfremer+watch_chromium.org, jam, avayvod+watch_chromium.org, darin-cc_chromium.org, mcasas+watch+vc_chromium.org, jasonroberts+watch_google.com, xjz+watch_chromium.org, isheriff+watch_chromium.org, miu+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Ignore invalid optional constraints with invalid aspect ratio. Failing to do this may lead to a CHECK in some cases. BUG=680687 Review-Url: https://codereview.chromium.org/2632633004 Cr-Commit-Position: refs/heads/master@{#443555} Committed: https://chromium.googlesource.com/chromium/src/+/be3576dd35b1cd9da3e71ad8f00cea203d3fcbd5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -1 line) Patch
M content/renderer/media/media_stream_video_source.cc View 1 chunk +4 lines, -1 line 0 comments Download
M content/renderer/media/media_stream_video_source_unittest.cc View 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Guido Urdaneta
Hi, PTAL
3 years, 11 months ago (2017-01-13 11:05:12 UTC) #3
hta - Chromium
lgtm
3 years, 11 months ago (2017-01-13 11:31:27 UTC) #6
hbos_chromium
lgtm
3 years, 11 months ago (2017-01-13 14:43:43 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2632633004/1
3 years, 11 months ago (2017-01-13 14:44:35 UTC) #11
commit-bot: I haz the power
3 years, 11 months ago (2017-01-13 14:48:26 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/be3576dd35b1cd9da3e71ad8f00c...

Powered by Google App Engine
This is Rietveld 408576698