Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 2632623002: [foozzie] Fix failure state for non-existing source output (Closed)

Created:
3 years, 11 months ago by Michael Achenbach
Modified:
3 years, 11 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[foozzie] Fix failure state for non-existing source output BUG=chromium:673246 NOTRY=true TBR=tandrii@chromium.org,mbarbella@chromium.org Review-Url: https://codereview.chromium.org/2632623002 Cr-Commit-Position: refs/heads/master@{#42306} Committed: https://chromium.googlesource.com/v8/v8/+/baf5a21751a837785718ed4d569599942fbb11e7

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -15 lines) Patch
M tools/foozzie/v8_foozzie.py View 4 chunks +2 lines, -7 lines 0 comments Download
M tools/foozzie/v8_suppressions.py View 7 chunks +14 lines, -8 lines 1 comment Download

Messages

Total messages: 9 (5 generated)
Michael Achenbach
TBR https://codereview.chromium.org/2632623002/diff/1/tools/foozzie/v8_suppressions.py File tools/foozzie/v8_suppressions.py (right): https://codereview.chromium.org/2632623002/diff/1/tools/foozzie/v8_suppressions.py#newcode233 tools/foozzie/v8_suppressions.py:233: source_key = hashlib.sha1(source).hexdigest()[:SOURCE_HASH_LENGTH] Maybe not ideal that this ...
3 years, 11 months ago (2017-01-13 08:13:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2632623002/1
3 years, 11 months ago (2017-01-13 08:13:56 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/v8/v8/+/baf5a21751a837785718ed4d569599942fbb11e7
3 years, 11 months ago (2017-01-13 08:15:41 UTC) #8
tandrii(chromium)
3 years, 11 months ago (2017-01-13 08:20:31 UTC) #9
Message was sent while issue was closed.
lgtm for short term fix.

Powered by Google App Engine
This is Rietveld 408576698