Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2632613003:
Improve crash format text for the captured & uploaded case. (Closed)
|
Created:
3 years, 11 months ago by Wez Modified:
3 years, 11 months ago Reviewers:
Robert Sesek CC:
chromium-reviews Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionImprove crash format text for the captured & uploaded case.
The previous wording was clumsy, and the format's description was not
sufficient for translators to understand the intended phrasing.
BUG=664430
,b/34237079
Review-Url: https://codereview.chromium.org/2632613003
Cr-Commit-Position: refs/heads/master@{#444656}
Committed: https://chromium.googlesource.com/chromium/src/+/a6d7142534246d479668c7ad7122d7864979e2b8
Patch Set 1 #
Total comments: 2
Patch Set 2 : Replace ampersand with and #Messages
Total messages: 21 (15 generated)
wez@chromium.org changed reviewers: + rsesek@chromium.org
PTAL ASAP; translators are waiting on my correcting the clumsy wording, to get translations in for branch cut.
The CQ bit was checked by wez@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Improve crash format text for the captured & uploaded case. The previous wording was clumsy, and the format's description was not sufficient for translators to understand the intended phrasing. BUG=664430 ========== to ========== Improve crash format text for the captured & uploaded case. The previous wording was clumsy, and the format's description was not sufficient for translators to understand the intended phrasing. BUG=664430, b/34237079 ==========
Description was changed from ========== Improve crash format text for the captured & uploaded case. The previous wording was clumsy, and the format's description was not sufficient for translators to understand the intended phrasing. BUG=664430, b/34237079 ========== to ========== Improve crash format text for the captured & uploaded case. The previous wording was clumsy, and the format's description was not sufficient for translators to understand the intended phrasing. BUG=664430,b/34237079 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
lgtm
https://codereview.chromium.org/2632613003/diff/1/components/crash_strings.grdp File components/crash_strings.grdp (right): https://codereview.chromium.org/2632613003/diff/1/components/crash_strings.gr... components/crash_strings.grdp:19: <message name="IDS_CRASH_CAPTURE_AND_UPLOAD_TIME_FORMAT" desc="Format for the time & date at which the crash report was captured, and subsequently uploaded, to display on chrome://crashes"> I bet the errors don't like this unescaped ampersand.
The CQ bit was checked by wez@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2632613003/diff/1/components/crash_strings.grdp File components/crash_strings.grdp (right): https://codereview.chromium.org/2632613003/diff/1/components/crash_strings.gr... components/crash_strings.grdp:19: <message name="IDS_CRASH_CAPTURE_AND_UPLOAD_TIME_FORMAT" desc="Format for the time & date at which the crash report was captured, and subsequently uploaded, to display on chrome://crashes"> On 2017/01/13 22:56:00, Robert Sesek wrote: > I bet the errors don't like this unescaped ampersand. I think I'd lose that bet; nice catch.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by wez@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from rsesek@chromium.org Link to the patchset: https://codereview.chromium.org/2632613003/#ps20001 (title: "Replace ampersand with and")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484803270445550,
"parent_rev": "6cbb47c4ee66492694a4798fbbd652046bce0ce0", "commit_rev":
"a6d7142534246d479668c7ad7122d7864979e2b8"}
Message was sent while issue was closed.
Description was changed from ========== Improve crash format text for the captured & uploaded case. The previous wording was clumsy, and the format's description was not sufficient for translators to understand the intended phrasing. BUG=664430,b/34237079 ========== to ========== Improve crash format text for the captured & uploaded case. The previous wording was clumsy, and the format's description was not sufficient for translators to understand the intended phrasing. BUG=664430,b/34237079 Review-Url: https://codereview.chromium.org/2632613003 Cr-Commit-Position: refs/heads/master@{#444656} Committed: https://chromium.googlesource.com/chromium/src/+/a6d7142534246d479668c7ad7122... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/a6d7142534246d479668c7ad7122... |
