Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1011)

Issue 2632603002: Add support for ASAN-specific test expectations to WebGL tests. (Closed)

Created:
3 years, 11 months ago by Ken Russell (switch to Gerrit)
Modified:
3 years, 11 months ago
Reviewers:
Zhenyao Mo
CC:
chromium-reviews, jam, darin-cc_chromium.org, piman+watch_chromium.org, Jamie Madill, fjhenigman, Kai Ninomiya, Corentin Wallez
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add support for ASAN-specific test expectations to WebGL tests. Because each test harness will need to explicitly add code to handle ASAN expectations, add the command-line flag only to the WebGL harness for now. Pass the appropriate command line argument on the Mac ASAN bot. Added unit tests for the new functionality. Fixed a preexisting bug with capitalization of test expectations. Added tests for it. BUG=680845 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2632603002 Cr-Commit-Position: refs/heads/master@{#443655} Committed: https://chromium.googlesource.com/chromium/src/+/c61df25bec9534e4393a744babaebd46be64e4bd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -20 lines) Patch
M content/test/gpu/generate_buildbot_json.py View 10 chunks +14 lines, -0 lines 0 comments Download
M content/test/gpu/gpu_tests/gpu_test_expectations.py View 1 chunk +3 lines, -2 lines 0 comments Download
M content/test/gpu/gpu_tests/test_expectations.py View 6 chunks +32 lines, -7 lines 0 comments Download
M content/test/gpu/gpu_tests/test_expectations_unittest.py View 4 chunks +33 lines, -2 lines 0 comments Download
M content/test/gpu/gpu_tests/webgl2_conformance_expectations.py View 2 chunks +16 lines, -2 lines 0 comments Download
M content/test/gpu/gpu_tests/webgl_conformance_expectations.py View 1 chunk +2 lines, -2 lines 0 comments Download
M content/test/gpu/gpu_tests/webgl_conformance_expectations_unittest.py View 1 chunk +1 line, -0 lines 0 comments Download
M content/test/gpu/gpu_tests/webgl_conformance_integration_test.py View 4 chunks +10 lines, -3 lines 0 comments Download
M testing/buildbot/chromium.gpu.fyi.json View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
Ken Russell (switch to Gerrit)
Mo: please review. Thanks. Others: FYI. It would be great if others would be interested ...
3 years, 11 months ago (2017-01-13 04:10:26 UTC) #3
Zhenyao Mo
On 2017/01/13 04:10:26, Ken Russell wrote: > Mo: please review. Thanks. > > Others: FYI. ...
3 years, 11 months ago (2017-01-13 19:03:00 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2632603002/1
3 years, 11 months ago (2017-01-13 19:31:49 UTC) #10
commit-bot: I haz the power
3 years, 11 months ago (2017-01-13 20:44:28 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c61df25bec9534e4393a744babae...

Powered by Google App Engine
This is Rietveld 408576698