Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Issue 2632593002: [wasm][asm.js] Don't squish error location because module end not reached. (Closed)

Created:
3 years, 11 months ago by bradnelson
Modified:
3 years, 11 months ago
Reviewers:
gdeepti, bradn
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm][asm.js] Don't squish error location because module end not reached. We recently started emitting an error because a module's validation doesn't reach the end (due to lack of exports). This contained a mistake that prevents many most other types of errors from actually getting out. Ensuring export errors (or not reaching then end) doesn't clobber other errors. TODO(bradnelson): Figure out a way to structure tests so this gets caught. BUG=v8:4203 R=gdeepti@chromium.org Review-Url: https://codereview.chromium.org/2632593002 Cr-Commit-Position: refs/heads/master@{#42301} Committed: https://chromium.googlesource.com/v8/v8/+/7d86a478d22c8ea7dbf16789229e9e1c0b8687ec

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/asmjs/asm-wasm-builder.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (6 generated)
gdeepti
lgtm
3 years, 11 months ago (2017-01-13 02:49:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2632593002/1
3 years, 11 months ago (2017-01-13 02:58:21 UTC) #6
commit-bot: I haz the power
3 years, 11 months ago (2017-01-13 03:38:54 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/7d86a478d22c8ea7dbf16789229e9e1c0b8...

Powered by Google App Engine
This is Rietveld 408576698