Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 2632583002: MemoryInfra: Remove few dump providers from thread check blacklist (Closed)

Created:
3 years, 11 months ago by ssid
Modified:
3 years, 11 months ago
CC:
chromium-reviews, tracing+reviews_chromium.org, wfh+watch_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MemoryInfra: Remove few dump providers from thread check blacklist This is to identify bugs in the memory-infra clients. Sheriffs: if this introduces crashes/flakes in memory tests revert the CL straight away. BUG=643438 Review-Url: https://codereview.chromium.org/2632583002 Cr-Commit-Position: refs/heads/master@{#444362} Committed: https://chromium.googlesource.com/chromium/src/+/72966cf642b6dcafe38fb223d5aa50df50658acc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
M base/trace_event/memory_dump_manager.cc View 2 chunks +0 lines, -7 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (9 generated)
ssid
I thought a little bit and came up with list of few providers that are ...
3 years, 11 months ago (2017-01-13 02:10:22 UTC) #2
Primiano Tucci (use gerrit)
LGTM. Maybe I'd reword slightly the commit message saying: This is to identify bugs in ...
3 years, 11 months ago (2017-01-16 14:41:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2632583002/1
3 years, 11 months ago (2017-01-18 15:23:02 UTC) #10
commit-bot: I haz the power
3 years, 11 months ago (2017-01-18 15:27:15 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/72966cf642b6dcafe38fb223d5aa...

Powered by Google App Engine
This is Rietveld 408576698