Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Unified Diff: ui/aura/mus/window_tree_client.cc

Issue 2632543003: Refactor and push window properties up to class properties. (Closed)
Patch Set: More build fixes Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/aura/mus/window_tree_client.cc
diff --git a/ui/aura/mus/window_tree_client.cc b/ui/aura/mus/window_tree_client.cc
index 8a20c9982485fa89a6d1d876f623911b54e080e5..5f73fbb14441b998bd131fb23754262ebcd3d516 100644
--- a/ui/aura/mus/window_tree_client.cc
+++ b/ui/aura/mus/window_tree_client.cc
@@ -69,7 +69,7 @@ inline uint16_t HiWord(uint32_t id) {
return static_cast<uint16_t>((id >> 16) & 0xFFFF);
}
-struct WindowPortPropertyDataMus : public WindowPortPropertyData {
+struct WindowPortPropertyDataMus : public ui::PropertyData {
std::string transport_name;
std::unique_ptr<std::vector<uint8_t>> transport_value;
};
@@ -596,7 +596,7 @@ void WindowTreeClient::OnWindowMusCreated(WindowMus* window) {
std::unordered_map<std::string, std::vector<uint8_t>> transport_properties;
std::set<const void*> property_keys =
- window->GetWindow()->GetAllPropertKeys();
+ window->GetWindow()->GetAllPropertyKeys();
PropertyConverter* property_converter = delegate_->GetPropertyConverter();
for (const void* key : property_keys) {
std::string transport_name;
@@ -712,7 +712,7 @@ void WindowTreeClient::OnWindowMusSetVisible(WindowMus* window, bool visible) {
tree_->SetWindowVisibility(change_id, window->server_id(), visible);
}
-std::unique_ptr<WindowPortPropertyData>
+std::unique_ptr<ui::PropertyData>
WindowTreeClient::OnWindowMusWillChangeProperty(WindowMus* window,
const void* key) {
if (IsInternalProperty(key))
@@ -731,7 +731,7 @@ WindowTreeClient::OnWindowMusWillChangeProperty(WindowMus* window,
void WindowTreeClient::OnWindowMusPropertyChanged(
WindowMus* window,
const void* key,
- std::unique_ptr<WindowPortPropertyData> data) {
+ std::unique_ptr<ui::PropertyData> data) {
if (HandleInternalPropertyChanged(window, key) || !data)
return;

Powered by Google App Engine
This is Rietveld 408576698