Add retry information to certificate reports.

Add retry information to certificate reports.

This CL adds a is_retry_upload to CertLoggerRequest proto that's set to
false by default. When a certificate report upload fails and is retried
for a second time, the flag is set to true. This will help identify new
certificate reports that are now being observed because of the report
retry feature.

BUG=679907
Review-Url: https://codereview.chromium.org/2632533002
Cr-Commit-Position: refs/heads/master@{#444232}
Committed: https://chromium.googlesource.com/chromium/src/+/c9b9670bc2ea41eeb69175f90771f6f034673e48

[meacer, 2017-01-12 23:06:46]

meacer@chromium.org changed reviewers:
+ estark@chromium.org, jialiul@chromium.org

[meacer, 2017-01-12 23:06:46]

estark, jialiul: PTAL?

[estark, 2017-01-13 23:26:23]

lgtm with a few nits

https://codereview.chromium.org/2632533002/diff/1/chrome/browser/safe_browsin...
File chrome/browser/safe_browsing/certificate_reporting_service.cc (right):

https://codereview.chromium.org/2632533002/diff/1/chrome/browser/safe_browsin...
chrome/browser/safe_browsing/certificate_reporting_service.cc:123: LOG(ERROR) <<
"Cannot deserialize report";
Is this possible? maybe should just be
DCHECK(error_report.InitialieFromString(...))?

https://codereview.chromium.org/2632533002/diff/1/chrome/browser/safe_browsin...
File chrome/browser/safe_browsing/certificate_reporting_service_test_utils.cc
(right):

https://codereview.chromium.org/2632533002/diff/1/chrome/browser/safe_browsin...
chrome/browser/safe_browsing/certificate_reporting_service_test_utils.cc:84:
bool ObservedReport::operator<(const ObservedReport& other) const {
Shouldn't these compare is_retried as well? (If that's not necessary for some
reason, maybe leave a comment in the .h)

https://codereview.chromium.org/2632533002/diff/1/chrome/browser/safe_browsin...
File chrome/browser/safe_browsing/certificate_reporting_service_test_utils.h
(right):

https://codereview.chromium.org/2632533002/diff/1/chrome/browser/safe_browsin...
chrome/browser/safe_browsing/certificate_reporting_service_test_utils.h:8:
#include <unordered_set>
looks like you're using normal <set> below; did you mean to change this?

https://codereview.chromium.org/2632533002/diff/1/chrome/browser/safe_browsin...
File chrome/browser/safe_browsing/certificate_reporting_service_unittest.cc
(right):

https://codereview.chromium.org/2632533002/diff/1/chrome/browser/safe_browsin...
chrome/browser/safe_browsing/certificate_reporting_service_unittest.cc:80: void
AssertReport(const CertificateReportingService::Report& report,
CheckReport?

https://codereview.chromium.org/2632533002/diff/1/components/certificate_repo...
File components/certificate_reporting/error_report.h (right):

https://codereview.chromium.org/2632533002/diff/1/components/certificate_repo...
components/certificate_reporting/error_report.h:74: // Sets is_retry_upload
field of the protobuf to |is_retry_upload|.
nit: blank line above (and above line 79)

[meacer, 2017-01-17 22:24:27]

https://codereview.chromium.org/2632533002/diff/1/chrome/browser/safe_browsin...
File chrome/browser/safe_browsing/certificate_reporting_service.cc (right):

https://codereview.chromium.org/2632533002/diff/1/chrome/browser/safe_browsin...
chrome/browser/safe_browsing/certificate_reporting_service.cc:123: LOG(ERROR) <<
"Cannot deserialize report";
On 2017/01/13 23:26:22, estark wrote:
> Is this possible? maybe should just be
> DCHECK(error_report.InitialieFromString(...))?

cert_report_helper seemed to imply it was possible, but perhaps that's not true
once it's already serialized. Converted to CHECKs (since DCHECKs would be
compiled out).

https://codereview.chromium.org/2632533002/diff/1/chrome/browser/safe_browsin...
File chrome/browser/safe_browsing/certificate_reporting_service_test_utils.cc
(right):

https://codereview.chromium.org/2632533002/diff/1/chrome/browser/safe_browsin...
chrome/browser/safe_browsing/certificate_reporting_service_test_utils.cc:84:
bool ObservedReport::operator<(const ObservedReport& other) const {
On 2017/01/13 23:26:22, estark wrote:
> Shouldn't these compare is_retried as well? (If that's not necessary for some
> reason, maybe leave a comment in the .h)

This was keying on the hostname, leaving is_retried out. But your comment made
me realize what we want is actually a map instead of a set, so changed std::set
to unordered map. ObservedReport struct is no longer needed.

https://codereview.chromium.org/2632533002/diff/1/chrome/browser/safe_browsin...
File chrome/browser/safe_browsing/certificate_reporting_service_test_utils.h
(right):

https://codereview.chromium.org/2632533002/diff/1/chrome/browser/safe_browsin...
chrome/browser/safe_browsing/certificate_reporting_service_test_utils.h:8:
#include <unordered_set>
On 2017/01/13 23:26:22, estark wrote:
> looks like you're using normal <set> below; did you mean to change this?

Changed to unordered_map.

https://codereview.chromium.org/2632533002/diff/1/chrome/browser/safe_browsin...
File chrome/browser/safe_browsing/certificate_reporting_service_unittest.cc
(right):

https://codereview.chromium.org/2632533002/diff/1/chrome/browser/safe_browsin...
chrome/browser/safe_browsing/certificate_reporting_service_unittest.cc:80: void
AssertReport(const CertificateReportingService::Report& report,
On 2017/01/13 23:26:22, estark wrote:
> CheckReport?

Done.

https://codereview.chromium.org/2632533002/diff/1/components/certificate_repo...
File components/certificate_reporting/error_report.h (right):

https://codereview.chromium.org/2632533002/diff/1/components/certificate_repo...
components/certificate_reporting/error_report.h:74: // Sets is_retry_upload
field of the protobuf to |is_retry_upload|.
On 2017/01/13 23:26:22, estark wrote:
> nit: blank line above (and above line 79)

Done.

[Jialiu Lin, 2017-01-17 22:31:42]

lgtm

(I had 2 nits in patch 1 and forgot to send them out. And seems you've already
fixed them in patch 2. )

[meacer, 2017-01-17 22:34:50]

On 2017/01/17 22:31:42, Jialiu Lin wrote:
> lgtm
> 
> (I had 2 nits in patch 1 and forgot to send them out. And seems you've already
> fixed them in patch 2. )

Awesome, thanks!

[meacer, 2017-01-17 22:34:54]

The CQ bit was checked by meacer@chromium.org

[meacer, 2017-01-17 22:34:54]

The patchset sent to the CQ was uploaded after l-g-t-m from estark@chromium.org
Link to the patchset: https://codereview.chromium.org/2632533002/#ps20001
(title: "estark comments, change set to map")

[commit-bot: I haz the power, 2017-01-17 22:35:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-17 22:57:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-17 22:57:47]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[meacer, 2017-01-18 00:09:30]

The CQ bit was checked by meacer@chromium.org

[meacer, 2017-01-18 00:09:30]

The patchset sent to the CQ was uploaded after l-g-t-m from
jialiul@chromium.org, estark@chromium.org
Link to the patchset: https://codereview.chromium.org/2632533002/#ps40001
(title: "Enums")

[commit-bot: I haz the power, 2017-01-18 00:10:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-18 01:36:15]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1484698170222510,
"parent_rev": "88f7b1a466df5baaf320fc809190d88ac2b5ebfe", "commit_rev":
"c9b9670bc2ea41eeb69175f90771f6f034673e48"}

[commit-bot: I haz the power, 2017-01-18 01:36:46]

Description was changed from

==========
Add retry information to certificate reports.

This CL adds a is_retry_upload to CertLoggerRequest proto that's set to
false by default. When a certificate report upload fails and is retried
for a second time, the flag is set to true. This will help identify new
certificate reports that are now being observed because of the report
retry feature.

BUG=679907
==========

to

==========
Add retry information to certificate reports.

This CL adds a is_retry_upload to CertLoggerRequest proto that's set to
false by default. When a certificate report upload fails and is retried
for a second time, the flag is set to true. This will help identify new
certificate reports that are now being observed because of the report
retry feature.

BUG=679907

Review-Url: https://codereview.chromium.org/2632533002
Cr-Commit-Position: refs/heads/master@{#444232}
Committed:
https://chromium.googlesource.com/chromium/src/+/c9b9670bc2ea41eeb69175f90771...
==========

[commit-bot: I haz the power, 2017-01-18 01:36:48]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/c9b9670bc2ea41eeb69175f90771...