Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 2632513002: PPC/s390: [debugger] infrastructure for side-effect-free debug-evaluate. (Closed)

Created:
3 years, 11 months ago by JaideepBajwa
Modified:
3 years, 11 months ago
CC:
v8-reviews_googlegroups.com, Yang
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC/s390: [debugger] infrastructure for side-effect-free debug-evaluate. Port aa75904e3c2072f6b0d6ed92f75d1fb729d7cefa R=yangguo@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG=v8:5821 LOG=N Review-Url: https://codereview.chromium.org/2632513002 Cr-Commit-Position: refs/heads/master@{#42292} Committed: https://chromium.googlesource.com/v8/v8/+/8194ff053f35cebe1d731735e3119ae529c1d33e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -51 lines) Patch
M src/builtins/ppc/builtins-ppc.cc View 2 chunks +6 lines, -7 lines 0 comments Download
M src/builtins/s390/builtins-s390.cc View 2 chunks +6 lines, -7 lines 0 comments Download
M src/debug/ppc/debug-ppc.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/debug/s390/debug-s390.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ppc/macro-assembler-ppc.h View 1 chunk +4 lines, -3 lines 0 comments Download
M src/ppc/macro-assembler-ppc.cc View 4 chunks +13 lines, -15 lines 0 comments Download
M src/s390/macro-assembler-s390.h View 1 chunk +4 lines, -3 lines 0 comments Download
M src/s390/macro-assembler-s390.cc View 4 chunks +13 lines, -14 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
JaideepBajwa
ptal
3 years, 11 months ago (2017-01-12 20:57:31 UTC) #1
john.yan
lgtm
3 years, 11 months ago (2017-01-12 21:00:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2632513002/1
3 years, 11 months ago (2017-01-12 21:00:41 UTC) #4
commit-bot: I haz the power
3 years, 11 months ago (2017-01-12 21:27:26 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/8194ff053f35cebe1d731735e3119ae529c...

Powered by Google App Engine
This is Rietveld 408576698