Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Unified Diff: content/browser/renderer_host/render_widget_host_view_android.h

Issue 2632493005: Disable Android virtual keyboard when in VR shell (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_view_android.h
diff --git a/content/browser/renderer_host/render_widget_host_view_android.h b/content/browser/renderer_host/render_widget_host_view_android.h
index 5ac2a2be7d0c6e08bf110a73b03ddbeed596cbf6..a3f9d66ab4bfcc382a3ec52a51957389a750041d 100644
--- a/content/browser/renderer_host/render_widget_host_view_android.h
+++ b/content/browser/renderer_host/render_widget_host_view_android.h
@@ -144,7 +144,7 @@ class CONTENT_EXPORT RenderWidgetHostViewAndroid
void OnSwapCompositorFrame(uint32_t compositor_frame_sink_id,
cc::CompositorFrame frame) override;
void ClearCompositorFrame() override;
- void SetShowingOverscrollGlow(bool showing_glow) override;
+ void SetIsInVR(bool is_in_vr) override;
void DidOverscroll(const ui::DidOverscrollParams& params) override;
void DidStopFlinging() override;
cc::FrameSinkId GetFrameSinkId() override;
@@ -329,8 +329,8 @@ class CONTENT_EXPORT RenderWidgetHostViewAndroid
bool is_window_visible_;
bool is_window_activity_started_;
- // Used to control the appearance of overscroll glow.
- bool is_showing_overscroll_glow_;
+ // Used to control the appearance of overscroll glow and keyboard.
cjgrant 2017/01/13 20:44:38 Should we just drop the comment? Whenever use of
Charlie Reis 2017/01/13 20:59:02 Alternatively, you can describe these as examples,
asimjour 2017/01/16 19:28:41 Comment is updated.
asimjour 2017/01/16 19:28:41 Done.
+ bool is_in_vr_;
// ContentViewCoreImpl is our interface to the view system.
ContentViewCoreImpl* content_view_core_;

Powered by Google App Engine
This is Rietveld 408576698