Disable Android virtual keyboard when in VR shell

content/browser/renderer_host/render_widget_host_view_android.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_VIEW_ANDROID_H_
 #define CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_VIEW_ANDROID_H_
 
 #include <stddef.h>
 #include <stdint.h>
 
@@ skipping 126 matching lines @@
   void OnSetNeedsFlushInput() override;
   void GestureEventAck(const blink::WebGestureEvent& event,
                        InputEventAckState ack_result) override;
   BrowserAccessibilityManager* CreateBrowserAccessibilityManager(
       BrowserAccessibilityDelegate* delegate, bool for_root_frame) override;
   bool LockMouse() override;
   void UnlockMouse() override;
   void OnSwapCompositorFrame(uint32_t compositor_frame_sink_id,
                              cc::CompositorFrame frame) override;
   void ClearCompositorFrame() override;
-  void SetShowingOverscrollGlow(bool showing_glow) override;
+  void SetIsInVR(bool is_in_vr) override;
   void DidOverscroll(const ui::DidOverscrollParams& params) override;
   void DidStopFlinging() override;
   cc::FrameSinkId GetFrameSinkId() override;
   void ShowDisambiguationPopup(const gfx::Rect& rect_pixels,
                                const SkBitmap& zoomed_bitmap) override;
   std::unique_ptr<SyntheticGestureTarget> CreateSyntheticGestureTarget()
       override;
   void LockCompositingSurface() override;
   void UnlockCompositingSurface() override;
   void OnDidNavigateMainFrameToNewPage() override;
@@ skipping 164 matching lines @@
   // Indicates whether and for what reason a request for begin frames has been
   // issued. Used to control action dispatch at the next |OnBeginFrame()| call.
   uint32_t outstanding_begin_frame_requests_;
 
   bool is_showing_;
 
   // Window-specific bits that affect widget visibility.
   bool is_window_visible_;
   bool is_window_activity_started_;
 
-  // Used to control the appearance of overscroll glow.
-  bool is_showing_overscroll_glow_;
+  // Used to control the appearance of overscroll glow and keyboard.

[cjgrant, 2017/01/13 20:44:38]

Should we just drop the comment?  Whenever use of the variable changes, the
comment will become stale.

[Charlie Reis, 2017/01/13 20:59:02]

Alternatively, you can describe these as examples, so that readers know why this
is useful but doesn't assume it's comprehensive.  Something like:

Used to customize behavior for virtual reality mode, such as the appearance of
overscroll glow and the keyboard.

[asimjour, 2017/01/16 19:28:41]

Comment is updated.

[asimjour, 2017/01/16 19:28:41]

Done.

+  bool is_in_vr_;
 
   // ContentViewCoreImpl is our interface to the view system.
   ContentViewCoreImpl* content_view_core_;
 
   ImeAdapterAndroid ime_adapter_android_;
 
   // Body background color of the underlying document.
   SkColor cached_background_color_;
 
   mutable ui::ViewAndroid view_;
@@ skipping 52 matching lines @@
   gfx::Vector2dF last_scroll_offset_;
 
   base::WeakPtrFactory<RenderWidgetHostViewAndroid> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(RenderWidgetHostViewAndroid);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_VIEW_ANDROID_H_