Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 2632473002: [iOS] Allow use of extra entitlements for EG tests. (Closed)

Created:
3 years, 11 months ago by bzanotti
Modified:
3 years, 11 months ago
Reviewers:
sdefresne
CC:
chromium-reviews, marq+watch_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[iOS] Allow use of extra entitlements for EG tests. Some internal tests require special entitlements (e.g. for keychain access). This was inadvertently dropped during the upstreaming. BUG=679042 Review-Url: https://codereview.chromium.org/2632473002 Cr-Commit-Position: refs/heads/master@{#443222} Committed: https://chromium.googlesource.com/chromium/src/+/45aeda552b74930b054e89ce116b1baa66c00834

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M ios/chrome/test/earl_grey/chrome_ios_eg_test.gni View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
bzanotti
Please take a look.
3 years, 11 months ago (2017-01-12 13:06:41 UTC) #2
sdefresne
lgtm
3 years, 11 months ago (2017-01-12 13:09:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2632473002/1
3 years, 11 months ago (2017-01-12 13:09:36 UTC) #5
commit-bot: I haz the power
3 years, 11 months ago (2017-01-12 14:14:25 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/45aeda552b74930b054e89ce116b...

Powered by Google App Engine
This is Rietveld 408576698