Android: Hook up aapt's main dex proguard rules

Android: Hook up aapt's main dex proguard rules

Noticed that aapt now has a flag for outputing a proguard rules file for
use when determining which classes to put in the main dex. For
ChromePublic.apk, it produces a file with a single rule:

-keep class org.chromium.chrome.browser.ChromeBackupAgent { <init>(...); }

Looks like this class wasn't already being explicitly kept in the main
dex, so it's possible that some part of backups was broken for debug
builds (where multidex is enabled).

BUG=none

Review-Url: https://codereview.chromium.org/2632463004
Cr-Commit-Position: refs/heads/master@{#443687}
Committed: https://chromium.googlesource.com/chromium/src/+/ba68db1ef24638f8e1eae8d12ff6a9fff0f1b096

[agrieve, 2017-01-13 15:32:08]

Description was changed from

==========
Android: Hook up aapt's main dex proguard rules

Noticed that aapt now has a flag for outputing a proguard rules file for
use when determining which classes to put in the main dex. For
ChromePublic.apk, it produces a file with a single rule:

-keep class org.chromium.chrome.browser.ChromeBackupAgent { <init>(...); }

Looks like this class wasn't already being explicitly kept in the main
dex, so it's possible that some part of backups was broken for debug
builds (where multidex is enabled).

BUG=none
==========

to

==========
Android: Hook up aapt's main dex proguard rules

Noticed that aapt now has a flag for outputing a proguard rules file for
use when determining which classes to put in the main dex. For
ChromePublic.apk, it produces a file with a single rule:

-keep class org.chromium.chrome.browser.ChromeBackupAgent { <init>(...); }

Looks like this class wasn't already being explicitly kept in the main
dex, so it's possible that some part of backups was broken for debug
builds (where multidex is enabled).

BUG=none
==========

[agrieve, 2017-01-13 15:32:08]

agrieve@chromium.org changed reviewers:
+ estevenson@chromium.org

[agrieve, 2017-01-13 15:32:22]

On 2017/01/13 15:32:08, agrieve wrote:
> mailto:agrieve@chromium.org changed reviewers:
> + mailto:estevenson@chromium.org

📐

[estevenson, 2017-01-13 16:35:12]

lgtm

https://codereview.chromium.org/2632463004/diff/1/build/config/android/intern...
File build/config/android/internal_rules.gni (right):

https://codereview.chromium.org/2632463004/diff/1/build/config/android/intern...
build/config/android/internal_rules.gni:948:
rebase_path(invoker.extra_main_dex_proguard_config, root_build_dir),
Should this also be an input?

[agrieve, 2017-01-13 17:58:39]

https://codereview.chromium.org/2632463004/diff/1/build/config/android/intern...
File build/config/android/internal_rules.gni (right):

https://codereview.chromium.org/2632463004/diff/1/build/config/android/intern...
build/config/android/internal_rules.gni:948:
rebase_path(invoker.extra_main_dex_proguard_config, root_build_dir),
On 2017/01/13 16:35:12, estevenson wrote:
> Should this also be an input?

Good catch! Done.

[agrieve, 2017-01-13 17:58:49]

The CQ bit was checked by agrieve@chromium.org

[agrieve, 2017-01-13 17:58:49]

The patchset sent to the CQ was uploaded after l-g-t-m from
estevenson@chromium.org
Link to the patchset: https://codereview.chromium.org/2632463004/#ps20001
(title: "add as input")

[commit-bot: I haz the power, 2017-01-13 17:59:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-13 20:30:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-13 20:30:10]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[agrieve, 2017-01-13 21:11:27]

The CQ bit was checked by agrieve@chromium.org

[commit-bot: I haz the power, 2017-01-13 21:12:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-13 21:53:55]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484341887489450,
"parent_rev": "37dd92324bb996ba0c96e27f1e54f8d0f511294c", "commit_rev":
"ba68db1ef24638f8e1eae8d12ff6a9fff0f1b096"}

[commit-bot: I haz the power, 2017-01-13 21:54:24]

Description was changed from

==========
Android: Hook up aapt's main dex proguard rules

Noticed that aapt now has a flag for outputing a proguard rules file for
use when determining which classes to put in the main dex. For
ChromePublic.apk, it produces a file with a single rule:

-keep class org.chromium.chrome.browser.ChromeBackupAgent { <init>(...); }

Looks like this class wasn't already being explicitly kept in the main
dex, so it's possible that some part of backups was broken for debug
builds (where multidex is enabled).

BUG=none
==========

to

==========
Android: Hook up aapt's main dex proguard rules

Noticed that aapt now has a flag for outputing a proguard rules file for
use when determining which classes to put in the main dex. For
ChromePublic.apk, it produces a file with a single rule:

-keep class org.chromium.chrome.browser.ChromeBackupAgent { <init>(...); }

Looks like this class wasn't already being explicitly kept in the main
dex, so it's possible that some part of backups was broken for debug
builds (where multidex is enabled).

BUG=none

Review-Url: https://codereview.chromium.org/2632463004
Cr-Commit-Position: refs/heads/master@{#443687}
Committed:
https://chromium.googlesource.com/chromium/src/+/ba68db1ef24638f8e1eae8d12ff6...
==========

[commit-bot: I haz the power, 2017-01-13 21:54:26]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/ba68db1ef24638f8e1eae8d12ff6...