Allow using a BrowserViewController without BookmarkModel for testing.

Allow using a BrowserViewController without BookmarkModel for testing.

Loading the bookmarks introduce some synchronisation point (as it is
done in a background sequence) which may be the causing the flakes
of BrowserViewWranglerTest.TestInitNilObserver.

Change BrowserViewController to works if the BookmarkModel has not
been created and change the test to not create it.

BUG=666816
Review-Url: https://codereview.chromium.org/2632393002
Cr-Commit-Position: refs/heads/master@{#444047}
Committed: https://chromium.googlesource.com/chromium/src/+/dc432f4211bfe92a50e6766d62ed8f833ab0c42d

[sdefresne, 2017-01-17 13:44:23]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-17 13:44:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sdefresne, 2017-01-17 13:44:44]

sdefresne@chromium.org changed reviewers:
+ marq@chromium.org

[sdefresne, 2017-01-17 13:44:45]

Please take a look.

[commit-bot: I haz the power, 2017-01-17 13:52:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-17 13:52:45]

Dry run: This issue passed the CQ dry run.

[marq (ping after 24h), 2017-01-17 14:30:24]

lgtm

[sdefresne, 2017-01-17 14:33:10]

The CQ bit was checked by sdefresne@chromium.org

[commit-bot: I haz the power, 2017-01-17 14:33:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-17 14:37:03]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1484663590887500, "parent_rev":
"7f1412bdbe40b21539aaf83fd831fa5bf1a85e92", "commit_rev":
"dc432f4211bfe92a50e6766d62ed8f833ab0c42d"}

[commit-bot: I haz the power, 2017-01-17 14:37:30]

Description was changed from

==========
Allow using a BrowserViewController without BookmarkModel for testing.

Loading the bookmarks introduce some synchronisation point (as it is
done in a background sequence) which may be the causing the flakes
of BrowserViewWranglerTest.TestInitNilObserver.

Change BrowserViewController to works if the BookmarkModel has not
been created and change the test to not create it.

BUG=666816
==========

to

==========
Allow using a BrowserViewController without BookmarkModel for testing.

Loading the bookmarks introduce some synchronisation point (as it is
done in a background sequence) which may be the causing the flakes
of BrowserViewWranglerTest.TestInitNilObserver.

Change BrowserViewController to works if the BookmarkModel has not
been created and change the test to not create it.

BUG=666816

Review-Url: https://codereview.chromium.org/2632393002
Cr-Commit-Position: refs/heads/master@{#444047}
Committed:
https://chromium.googlesource.com/chromium/src/+/dc432f4211bfe92a50e6766d62ed...
==========

[commit-bot: I haz the power, 2017-01-17 14:37:31]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/dc432f4211bfe92a50e6766d62ed...