Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(791)

Issue 2632373003: Throw correct error when connecting to different context. (Closed)

Created:
3 years, 11 months ago by Raymond Toy
Modified:
3 years, 11 months ago
Reviewers:
hongchan
CC:
chromium-reviews, blink-reviews, haraken, Raymond Toy, hongchan
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Throw correct error when connecting to different context. When connecting an AudioNode to a node from a different context, we were throwing a SyntaxError instead of an InvalidAccessError as specified in https://webaudio.github.io/web-audio-api/#widl-AudioNode-connect-AudioNode-AudioNode-destination-unsigned-long-output-unsigned-long-input Throw the expected error type. BUG=682040 TEST=audionode-connect-method-chaining.html Review-Url: https://codereview.chromium.org/2632373003 Cr-Commit-Position: refs/heads/master@{#444805} Committed: https://chromium.googlesource.com/chromium/src/+/f2c4a3b373c281d37f2a92717ebb63f7787463ba

Patch Set 1 #

Patch Set 2 : Fix typo. #

Patch Set 3 : Update tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M third_party/WebKit/LayoutTests/webaudio/AudioNode/audionode-connect-method-chaining.html View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/AudioNode/audionode-connect-method-chaining-expected.txt View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/dom-exceptions-expected.txt View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AudioNode.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (6 generated)
Raymond Toy
PTAL.
3 years, 11 months ago (2017-01-18 00:02:47 UTC) #4
hongchan
lgtm
3 years, 11 months ago (2017-01-19 12:17:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2632373003/40001
3 years, 11 months ago (2017-01-19 16:18:09 UTC) #7
commit-bot: I haz the power
3 years, 11 months ago (2017-01-19 18:59:35 UTC) #10
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/f2c4a3b373c281d37f2a92717ebb...

Powered by Google App Engine
This is Rietveld 408576698