The CQ bit was checked by rtoy@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
rtoy@chromium.org changed reviewers: + hongchan@chromium.org
PTAL.
lgtm
The CQ bit was checked by rtoy@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 40001, "attempt_start_ts": 1484842672804120, "parent_rev": "adcbc7bd0e5122b0923cb27852c7f0fd965248a5", "commit_rev": "f2c4a3b373c281d37f2a92717ebb63f7787463ba"}
Description was changed from ========== Throw correct error when connecting to different context. When connecting an AudioNode to a node from a different context, we were throwing a SyntaxError instead of an InvalidAccessError as specified in https://webaudio.github.io/web-audio-api/#widl-AudioNode-connect-AudioNode-Au... Throw the expected error type. BUG=682040 TEST=audionode-connect-method-chaining.html ========== to ========== Throw correct error when connecting to different context. When connecting an AudioNode to a node from a different context, we were throwing a SyntaxError instead of an InvalidAccessError as specified in https://webaudio.github.io/web-audio-api/#widl-AudioNode-connect-AudioNode-Au... Throw the expected error type. BUG=682040 TEST=audionode-connect-method-chaining.html Review-Url: https://codereview.chromium.org/2632373003 Cr-Commit-Position: refs/heads/master@{#444805} Committed: https://chromium.googlesource.com/chromium/src/+/f2c4a3b373c281d37f2a92717ebb... ==========
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/f2c4a3b373c281d37f2a92717ebb...