Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2632323002:
Move SearchInputType timers to frame-specific TaskRunnerTimer. (Closed)
|
Created:
3 years, 11 months ago by joelhockey Modified:
3 years, 11 months ago CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionMove SearchInputType timer to frame-specific TaskRunnerTimer.
Move SearchInputType timer m_searchEventTimer to frame-specific
TaskRunnerTimer. This associates it with the frame's
UserInteraction timer task
queue.
BUG=624694
Review-Url: https://codereview.chromium.org/2632323002
Cr-Commit-Position: refs/heads/master@{#444019}
Committed: https://chromium.googlesource.com/chromium/src/+/bcccdc917eabeb68408f1eddd539fba29ee8c9fe
Patch Set 1 #Patch Set 2 : work #
Messages
Total messages: 26 (17 generated)
The CQ bit was checked by joelhockey@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
joelhockey@chromium.org changed reviewers: + sashab@chromium.org
CL description: 'timer' not 'timers'. Please also add a bit more context and detail to CL description, e.g.: Move SearchInputType timer to frame-specific TaskRunnerTimer. Move SearchInputType timer m_searchEventTimer to frame-specific TaskRunnerTimer. This associates it wuith the frame's timer task queue. Also wrap desc to 72 chars :)
Description was changed from ========== Move SearchInputType timers to frame-specific TaskRunnerTimer. BUG=624694 ========== to ========== Move SearchInputType timer to frame-specific TaskRunnerTimer. Move SearchInputType timer m_searchEventTimer to frame-specific TaskRunnerTimer. This associates it with the frame's timer task queue. BUG=624694 ==========
On 2017/01/17 at 04:27:33, sashab wrote: > CL description: 'timer' not 'timers'. Please also add a bit more context and detail to CL description, e.g.: > > Move SearchInputType timer to frame-specific TaskRunnerTimer. > > Move SearchInputType timer m_searchEventTimer to frame-specific TaskRunnerTimer. This associates it wuith the frame's timer task queue. > > Also wrap desc to 72 chars :) Done.
joelhockey@chromium.org changed reviewers: + haraken@chromium.org
joelhockey@chromium.org changed required reviewers: + haraken@chromium.org, sashab@chromium.org
joelhockey@chromium.org changed required reviewers: - haraken@chromium.org, sashab@chromium.org
Please wrap description to 72 chars :) Other than that LGTM
This is a speced event. I think we should use the user interaction task source. https://html.spec.whatwg.org/multipage/forms.html#common-input-element-events
Description was changed from ========== Move SearchInputType timer to frame-specific TaskRunnerTimer. Move SearchInputType timer m_searchEventTimer to frame-specific TaskRunnerTimer. This associates it with the frame's timer task queue. BUG=624694 ========== to ========== Move SearchInputType timer to frame-specific TaskRunnerTimer. Move SearchInputType timer m_searchEventTimer to frame-specific TaskRunnerTimer. This associates it with the frame's timer task queue. BUG=624694 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
On 2017/01/17 at 06:34:18, haraken wrote: > This is a speced event. I think we should use the user interaction task source. > > https://html.spec.whatwg.org/multipage/forms.html#common-input-element-events Changed to TaskType::UserInteraction.
Description was changed from ========== Move SearchInputType timer to frame-specific TaskRunnerTimer. Move SearchInputType timer m_searchEventTimer to frame-specific TaskRunnerTimer. This associates it with the frame's timer task queue. BUG=624694 ========== to ========== Move SearchInputType timer to frame-specific TaskRunnerTimer. Move SearchInputType timer m_searchEventTimer to frame-specific TaskRunnerTimer. This associates it with the frame's UserInteraction timer task queue. BUG=624694 ==========
LGTM
The CQ bit was checked by haraken@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from sashab@chromium.org Link to the patchset: https://codereview.chromium.org/2632323002/#ps20001 (title: "work")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484644007462460,
"parent_rev": "7f95b5eacc1767fe93f9c475d285fa37935980fc", "commit_rev":
"bcccdc917eabeb68408f1eddd539fba29ee8c9fe"}
Message was sent while issue was closed.
Description was changed from ========== Move SearchInputType timer to frame-specific TaskRunnerTimer. Move SearchInputType timer m_searchEventTimer to frame-specific TaskRunnerTimer. This associates it with the frame's UserInteraction timer task queue. BUG=624694 ========== to ========== Move SearchInputType timer to frame-specific TaskRunnerTimer. Move SearchInputType timer m_searchEventTimer to frame-specific TaskRunnerTimer. This associates it with the frame's UserInteraction timer task queue. BUG=624694 Review-Url: https://codereview.chromium.org/2632323002 Cr-Commit-Position: refs/heads/master@{#444019} Committed: https://chromium.googlesource.com/chromium/src/+/bcccdc917eabeb68408f1eddd539... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/bcccdc917eabeb68408f1eddd539...
Message was sent while issue was closed.
Patchset #3 (id:40001) has been deleted
Message was sent while issue was closed.
Patchset #3 (id:60001) has been deleted |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
