Move ReferencedSurfaceTracker into GpuCompositorFrameSink.

Move ReferencedSurfaceTracker into GpuCompositorFrameSink.

Move the logic for adding/removing references from the client to the
GPU. We already pass a list of referenced surfaces, so just use that
list to compute a diff from the last submitted frame. This will
simplifying all clients and make removing SurfaceSequences easier in the
future. Add ReferencedSurfaceTracker to simplify this.

Also move add/removing top-level root references into
GpuCompositorFrameSink. This simplifies code in the mus Window Server.
FrameGenerator just needs to fill in
CompositorFrameMetadata::referenced_surfaces and clients that use
SurfaceLayers should just work.

This change only affects mustash, since non-mustash Chrome doesn't use
the Mojo interface for submitting CompositorFrames yet.

BUG=659227
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2632273003
Cr-Commit-Position: refs/heads/master@{#444774}
Committed: https://chromium.googlesource.com/chromium/src/+/4e728beb8a92c33105c7562bf11bac2e3ece1eb7

[kylechar, 2017-01-16 20:00:12]

Description was changed from

==========
Move EmbeddedSurfaceTracker into GpuCompositorFrameSink.

We have a list of referenced surfaces contained in
CompositorFrameMetadata. Move the code that adds/remove references into
the GPU process and use the list of referenced surfaces compared with
the last list.

Also move add/removing TLR references into GpuCompositorFrameSink.

This simplifies all of the clients. Remove some associated Mojo IPC
messages and lots of other code from clients.

BUG=
==========

to

==========
Move EmbeddedSurfaceTracker into GpuCompositorFrameSink.

We have a list of referenced surfaces contained in
CompositorFrameMetadata. Move the code that adds/remove references into
the GPU process and use the list of referenced surfaces compared with
the last list.

Also move add/removing TLR references into GpuCompositorFrameSink.

This simplifies all of the clients. Remove some associated Mojo IPC
messages and lots of other code from clients.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[kylechar, 2017-01-16 20:50:46]

Description was changed from

==========
Move EmbeddedSurfaceTracker into GpuCompositorFrameSink.

We have a list of referenced surfaces contained in
CompositorFrameMetadata. Move the code that adds/remove references into
the GPU process and use the list of referenced surfaces compared with
the last list.

Also move add/removing TLR references into GpuCompositorFrameSink.

This simplifies all of the clients. Remove some associated Mojo IPC
messages and lots of other code from clients.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Move EmbeddedSurfaceTracker into GpuCompositorFrameSink.

We have a list of referenced surfaces contained in
CompositorFrameMetadata. Move the code that adds/remove references into
the GPU process and use the list of referenced surfaces compared with
the last list.

Also move add/removing TLR references into GpuCompositorFrameSink. This
simplifies code in the WS greatly. FrameGenerator just needs to fill in
CompositorFrameMetadata::referenced_surfaces, which is only ever the
active WM surface. This also allows clients that use SurfaceLayers to
just work.

Remove some associated Mojo IPC messages for adding/removing references
and for passing the TLR SurfaceId to the DisplayCompositorClient.

BUG=659227
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[kylechar, 2017-01-16 21:11:45]

Description was changed from

==========
Move EmbeddedSurfaceTracker into GpuCompositorFrameSink.

We have a list of referenced surfaces contained in
CompositorFrameMetadata. Move the code that adds/remove references into
the GPU process and use the list of referenced surfaces compared with
the last list.

Also move add/removing TLR references into GpuCompositorFrameSink. This
simplifies code in the WS greatly. FrameGenerator just needs to fill in
CompositorFrameMetadata::referenced_surfaces, which is only ever the
active WM surface. This also allows clients that use SurfaceLayers to
just work.

Remove some associated Mojo IPC messages for adding/removing references
and for passing the TLR SurfaceId to the DisplayCompositorClient.

BUG=659227
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Move EmbeddedSurfaceTracker into GpuCompositorFrameSink.

Move the logic for adding/removing references from the client to the
GPU. We already pass a list of referenced surfaces, so just use that
list to compute a diff from the last submitted frame. This will
simplifying all clients and make removing SurfaceSequences easier in the
future.

Also move add/removing TLR references into GpuCompositorFrameSink. This
simplifies code in the WS. FrameGenerator just needs to fill in
CompositorFrameMetadata::referenced_surfaces and clients that use
SurfaceLayers should just work.

This change only affects mustash, since non-mustash Chrome doesn't use
the Mojo interface for submitting CompositorFrames yet.

BUG=659227
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[kylechar, 2017-01-16 21:12:35]

kylechar@chromium.org changed reviewers:
+ fsamuel@chromium.org, jbauman@chromium.org

[kylechar, 2017-01-16 21:12:36]

+jbauman for cc/surfaces/*
+fsamuel for services/ui/ws/*

[kylechar, 2017-01-16 21:12:50]

Description was changed from

==========
Move EmbeddedSurfaceTracker into GpuCompositorFrameSink.

Move the logic for adding/removing references from the client to the
GPU. We already pass a list of referenced surfaces, so just use that
list to compute a diff from the last submitted frame. This will
simplifying all clients and make removing SurfaceSequences easier in the
future.

Also move add/removing TLR references into GpuCompositorFrameSink. This
simplifies code in the WS. FrameGenerator just needs to fill in
CompositorFrameMetadata::referenced_surfaces and clients that use
SurfaceLayers should just work.

This change only affects mustash, since non-mustash Chrome doesn't use
the Mojo interface for submitting CompositorFrames yet.

BUG=659227
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Move ReferencedSurfaceTracker into GpuCompositorFrameSink.

Move the logic for adding/removing references from the client to the
GPU. We already pass a list of referenced surfaces, so just use that
list to compute a diff from the last submitted frame. This will
simplifying all clients and make removing SurfaceSequences easier in the
future.

Also move add/removing TLR references into GpuCompositorFrameSink. This
simplifies code in the WS. FrameGenerator just needs to fill in
CompositorFrameMetadata::referenced_surfaces and clients that use
SurfaceLayers should just work.

This change only affects mustash, since non-mustash Chrome doesn't use
the Mojo interface for submitting CompositorFrames yet.

BUG=659227
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[kylechar, 2017-01-16 21:19:54]

Description was changed from

==========
Move ReferencedSurfaceTracker into GpuCompositorFrameSink.

Move the logic for adding/removing references from the client to the
GPU. We already pass a list of referenced surfaces, so just use that
list to compute a diff from the last submitted frame. This will
simplifying all clients and make removing SurfaceSequences easier in the
future.

Also move add/removing TLR references into GpuCompositorFrameSink. This
simplifies code in the WS. FrameGenerator just needs to fill in
CompositorFrameMetadata::referenced_surfaces and clients that use
SurfaceLayers should just work.

This change only affects mustash, since non-mustash Chrome doesn't use
the Mojo interface for submitting CompositorFrames yet.

BUG=659227
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Move ReferencedSurfaceTracker into GpuCompositorFrameSink.

Move the logic for adding/removing references from the client to the
GPU. We already pass a list of referenced surfaces, so just use that
list to compute a diff from the last submitted frame. This will
simplifying all clients and make removing SurfaceSequences easier in the
future.

Also move add/removing top-level root references into
GpuCompositorFrameSink. This simplifies code in the mus Window Server.
FrameGenerator just needs to fill in
CompositorFrameMetadata::referenced_surfaces and clients that use
SurfaceLayers should just work.

This change only affects mustash, since non-mustash Chrome doesn't use
the Mojo interface for submitting CompositorFrames yet.

BUG=659227
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[kylechar, 2017-01-17 19:27:57]

I left some debug code in SurfaceManager accidentally, I've removed that code in
the latest patch.

[Fady Samuel, 2017-01-18 01:08:55]

https://codereview.chromium.org/2632273003/diff/60001/cc/surfaces/referenced_...
File cc/surfaces/referenced_surface_tracker.cc (right):

https://codereview.chromium.org/2632273003/diff/60001/cc/surfaces/referenced_...
cc/surfaces/referenced_surface_tracker.cc:47: // aren't already referenced.
Can you use std::set_difference?

[kylechar, 2017-01-18 15:20:15]

https://codereview.chromium.org/2632273003/diff/60001/cc/surfaces/referenced_...
File cc/surfaces/referenced_surface_tracker.cc (right):

https://codereview.chromium.org/2632273003/diff/60001/cc/surfaces/referenced_...
cc/surfaces/referenced_surface_tracker.cc:47: // aren't already referenced.
On 2017/01/18 01:08:55, Fady Samuel wrote:
> Can you use std::set_difference?

It's possible but I don't think the right solution. It's more code than the for
loop and it produces extra copies, since set_difference needs a temporary
collection to output to that will get destroyed at the end of the method. I
cleaned this up a bit to make it more understandable though.

[Fady Samuel, 2017-01-18 20:47:40]

lgtm + maybe pass to Dana?

https://codereview.chromium.org/2632273003/diff/80001/cc/surfaces/referenced_...
File cc/surfaces/referenced_surface_tracker.h (right):

https://codereview.chromium.org/2632273003/diff/80001/cc/surfaces/referenced_...
cc/surfaces/referenced_surface_tracker.h:49: void UpdateReferencedSurfaces(
Maybe call this UpdateReferencedSurfacesInternal so that it's clear this isn't
part of the class' API.

[kylechar, 2017-01-18 20:51:13]

Description was changed from

==========
Move ReferencedSurfaceTracker into GpuCompositorFrameSink.

Move the logic for adding/removing references from the client to the
GPU. We already pass a list of referenced surfaces, so just use that
list to compute a diff from the last submitted frame. This will
simplifying all clients and make removing SurfaceSequences easier in the
future.

Also move add/removing top-level root references into
GpuCompositorFrameSink. This simplifies code in the mus Window Server.
FrameGenerator just needs to fill in
CompositorFrameMetadata::referenced_surfaces and clients that use
SurfaceLayers should just work.

This change only affects mustash, since non-mustash Chrome doesn't use
the Mojo interface for submitting CompositorFrames yet.

BUG=659227
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Move ReferencedSurfaceTracker into GpuCompositorFrameSink.

Move the logic for adding/removing references from the client to the
GPU. We already pass a list of referenced surfaces, so just use that
list to compute a diff from the last submitted frame. This will
simplifying all clients and make removing SurfaceSequences easier in the
future. Add ReferencedSurfaceTracker to simplify this.

Also move add/removing top-level root references into
GpuCompositorFrameSink. This simplifies code in the mus Window Server.
FrameGenerator just needs to fill in
CompositorFrameMetadata::referenced_surfaces and clients that use
SurfaceLayers should just work.

This change only affects mustash, since non-mustash Chrome doesn't use
the Mojo interface for submitting CompositorFrames yet.

BUG=659227
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[kylechar, 2017-01-18 20:52:27]

kylechar@chromium.org changed reviewers:
+ danakj@chromium.org

[kylechar, 2017-01-18 20:52:28]

+danakj for cc/surfaces/* OWNERS and general review.

https://codereview.chromium.org/2632273003/diff/80001/cc/surfaces/referenced_...
File cc/surfaces/referenced_surface_tracker.h (right):

https://codereview.chromium.org/2632273003/diff/80001/cc/surfaces/referenced_...
cc/surfaces/referenced_surface_tracker.h:49: void UpdateReferencedSurfaces(
On 2017/01/18 20:47:40, Fady Samuel wrote:
> Maybe call this UpdateReferencedSurfacesInternal so that it's clear this isn't
> part of the class' API.

Change named to something less similar sound, done!

[jbauman, 2017-01-18 21:43:31]

lgtm

[kylechar, 2017-01-18 22:12:26]

kylechar@chromium.org changed reviewers:
+ reveman@chromium.org, sky@chromium.org, tsepez@chromium.org, xlai@chromium.org
- danakj@chromium.org

[kylechar, 2017-01-18 22:12:27]

+reveman for components/exo/*
+xlai for content/browser/renderer_host/*
+sky for services/ui/ws/*
+tsepez for *.mojom

[xlai (Olivia), 2017-01-18 22:15:28]

LGTM for content/browser/renderer_host/*

[reveman, 2017-01-18 22:18:21]

components/exo lgtm

[Tom Sepez, 2017-01-18 22:39:13]

lgtm

[sky, 2017-01-18 23:34:42]

LGTM

[kylechar, 2017-01-19 03:40:10]

The CQ bit was checked by kylechar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-19 03:40:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-19 03:43:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-19 03:43:12]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[kylechar, 2017-01-19 03:46:35]

The CQ bit was checked by kylechar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-19 03:46:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kylechar, 2017-01-19 04:03:39]

The CQ bit was unchecked by kylechar@chromium.org

[kylechar, 2017-01-19 04:03:39]

The CQ bit was checked by kylechar@chromium.org

[kylechar, 2017-01-19 04:03:40]

The patchset sent to the CQ was uploaded after l-g-t-m from
fsamuel@chromium.org, reveman@chromium.org, sky@chromium.org,
jbauman@chromium.org, tsepez@chromium.org, xlai@chromium.org
Link to the patchset: https://codereview.chromium.org/2632273003/#ps120001
(title: "Rebase.")

[commit-bot: I haz the power, 2017-01-19 04:04:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-19 04:31:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-19 04:31:12]

Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[kylechar, 2017-01-19 15:38:24]

The CQ bit was checked by kylechar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-19 15:38:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-19 17:13:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-19 17:13:18]

Dry run: This issue passed the CQ dry run.

[kylechar, 2017-01-19 17:33:16]

The CQ bit was checked by kylechar@chromium.org

[kylechar, 2017-01-19 17:33:16]

The patchset sent to the CQ was uploaded after l-g-t-m from
reveman@chromium.org, sky@chromium.org, jbauman@chromium.org,
tsepez@chromium.org, fsamuel@chromium.org, xlai@chromium.org
Link to the patchset: https://codereview.chromium.org/2632273003/#ps160001
(title: "Fix iterator invalidation.")

[commit-bot: I haz the power, 2017-01-19 17:33:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-19 17:39:34]

CQ is committing da patch.

Bot data: {"patchset_id": 160001, "attempt_start_ts": 1484847196236950,
"parent_rev": "4b470c5b3ffd5b74476cb3ffbcf3ff416ea30d72", "commit_rev":
"4e728beb8a92c33105c7562bf11bac2e3ece1eb7"}

[commit-bot: I haz the power, 2017-01-19 17:40:07]

Description was changed from

==========
Move ReferencedSurfaceTracker into GpuCompositorFrameSink.

Move the logic for adding/removing references from the client to the
GPU. We already pass a list of referenced surfaces, so just use that
list to compute a diff from the last submitted frame. This will
simplifying all clients and make removing SurfaceSequences easier in the
future. Add ReferencedSurfaceTracker to simplify this.

Also move add/removing top-level root references into
GpuCompositorFrameSink. This simplifies code in the mus Window Server.
FrameGenerator just needs to fill in
CompositorFrameMetadata::referenced_surfaces and clients that use
SurfaceLayers should just work.

This change only affects mustash, since non-mustash Chrome doesn't use
the Mojo interface for submitting CompositorFrames yet.

BUG=659227
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Move ReferencedSurfaceTracker into GpuCompositorFrameSink.

Move the logic for adding/removing references from the client to the
GPU. We already pass a list of referenced surfaces, so just use that
list to compute a diff from the last submitted frame. This will
simplifying all clients and make removing SurfaceSequences easier in the
future. Add ReferencedSurfaceTracker to simplify this.

Also move add/removing top-level root references into
GpuCompositorFrameSink. This simplifies code in the mus Window Server.
FrameGenerator just needs to fill in
CompositorFrameMetadata::referenced_surfaces and clients that use
SurfaceLayers should just work.

This change only affects mustash, since non-mustash Chrome doesn't use
the Mojo interface for submitting CompositorFrames yet.

BUG=659227
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2632273003
Cr-Commit-Position: refs/heads/master@{#444774}
Committed:
https://chromium.googlesource.com/chromium/src/+/4e728beb8a92c33105c7562bf11b...
==========

[commit-bot: I haz the power, 2017-01-19 17:40:09]

Committed patchset #9 (id:160001) as
https://chromium.googlesource.com/chromium/src/+/4e728beb8a92c33105c7562bf11b...