Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2632243005:
[Mojo Loading] Cancel loading in a timely manner (Closed)
|
Created:
3 years, 11 months ago by yhirano Modified:
3 years, 11 months ago CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, tzik, serviceworker-reviews, jam, Randy Smith (Not in Mondays), yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, kinuko+serviceworker, blink-worker-reviews_chromium.org, darin-cc_chromium.org, nhiroki, loading-reviews_chromium.org, horo+watch_chromium.org, darin (slow to review), shimazu+serviceworker_chromium.org, kinuko+watch, mmenke Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[Mojo Loading] Cancel loading in a timely manner
A mojo resource loading is cancelled when the associated URLLoader is destructed.
This CL moves the destruction timing from the PendingRequestInfo destruction
timing to the timing when ResourceDispatcher::RemovePendingRequest is called
in order to be aligned with the existing impelementation with IPC.
BUG=603396
Review-Url: https://codereview.chromium.org/2632243005
Cr-Commit-Position: refs/heads/master@{#444641}
Committed: https://chromium.googlesource.com/chromium/src/+/3b6cc5bcfd2a9275549e49b8ecc6d6b8b8bb9773
Patch Set 1 #Patch Set 2 : fix #Patch Set 3 : rebase #
Depends on Patchset: Messages
Total messages: 29 (23 generated)
The CQ bit was checked by yhirano@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by yhirano@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== [Mojo Loading] Add URLLoader::Cancel Currently, loading is cancelled when the associated URLLoader is destructed. But there is an ordering issue with the existing IPCs: An IPC message sent AFTER the URLLoader is destructed can arrive BEFORE the loading is cancelled in the browser process. This CL adds an explicit Cancel message to address browser test failures. BUG=603396 ========== to ========== [Mojo Loading] Cancel loading in a timely manner A mojo resource loading is cancelled when the associated URLLoader is destructed. This CL moves the destruction timing from the PendingRequestInfo destruction timing to the timing when ResourceDispatcher::RemovePendingRequest is called in order to fix some browser test failures. BUG=603396 ==========
Description was changed from ========== [Mojo Loading] Cancel loading in a timely manner A mojo resource loading is cancelled when the associated URLLoader is destructed. This CL moves the destruction timing from the PendingRequestInfo destruction timing to the timing when ResourceDispatcher::RemovePendingRequest is called in order to fix some browser test failures. BUG=603396 ========== to ========== [Mojo Loading] Cancel loading in a timely manner A mojo resource loading is cancelled when the associated URLLoader is destructed. This CL moves the destruction timing from the PendingRequestInfo destruction timing to the timing when ResourceDispatcher::RemovePendingRequest is called in order to fix some browser test failures. BUG=603396 ==========
Description was changed from ========== [Mojo Loading] Cancel loading in a timely manner A mojo resource loading is cancelled when the associated URLLoader is destructed. This CL moves the destruction timing from the PendingRequestInfo destruction timing to the timing when ResourceDispatcher::RemovePendingRequest is called in order to fix some browser test failures. BUG=603396 ========== to ========== [Mojo Loading] Cancel loading in a timely manner A mojo resource loading is cancelled when the associated URLLoader is destructed. This CL moves the destruction timing from the PendingRequestInfo destruction timing to the timing when ResourceDispatcher::RemovePendingRequest is called in order to be aligned with the existing impelementation with IPC. BUG=603396 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
yhirano@chromium.org changed reviewers: + tzik@chromium.org
lgtm
yhirano@chromium.org changed reviewers: + jam@chromium.org
+jam@ for OWNER review.
lgtm
The CQ bit was checked by yhirano@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by yhirano@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by yhirano@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from jam@chromium.org, tzik@chromium.org Link to the patchset: https://codereview.chromium.org/2632243005/#ps40001 (title: "rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1484799805643330,
"parent_rev": "0524c631c52912ac91c931e720cac0c6330c850e", "commit_rev":
"3b6cc5bcfd2a9275549e49b8ecc6d6b8b8bb9773"}
Message was sent while issue was closed.
Description was changed from ========== [Mojo Loading] Cancel loading in a timely manner A mojo resource loading is cancelled when the associated URLLoader is destructed. This CL moves the destruction timing from the PendingRequestInfo destruction timing to the timing when ResourceDispatcher::RemovePendingRequest is called in order to be aligned with the existing impelementation with IPC. BUG=603396 ========== to ========== [Mojo Loading] Cancel loading in a timely manner A mojo resource loading is cancelled when the associated URLLoader is destructed. This CL moves the destruction timing from the PendingRequestInfo destruction timing to the timing when ResourceDispatcher::RemovePendingRequest is called in order to be aligned with the existing impelementation with IPC. BUG=603396 Review-Url: https://codereview.chromium.org/2632243005 Cr-Commit-Position: refs/heads/master@{#444641} Committed: https://chromium.googlesource.com/chromium/src/+/3b6cc5bcfd2a9275549e49b8ecc6... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/3b6cc5bcfd2a9275549e49b8ecc6... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
