Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 2632223002: [foozzie] Add test suppressions (Closed)

Created:
3 years, 11 months ago by Michael Achenbach
Modified:
3 years, 11 months ago
Reviewers:
titzer, bradnelson, bradn
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : moar #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -4 lines) Patch
M tools/foozzie/v8_suppressions.py View 1 2 1 chunk +15 lines, -4 lines 1 comment Download

Messages

Total messages: 11 (7 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2632223002/40001
3 years, 11 months ago (2017-01-17 12:23:42 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/v8/v8/+/e9981e076acc92709a5a12361d5ab03a9bf5144a
3 years, 11 months ago (2017-01-17 12:25:20 UTC) #8
Michael Achenbach
https://codereview.chromium.org/2632223002/diff/40001/tools/foozzie/v8_suppressions.py File tools/foozzie/v8_suppressions.py (right): https://codereview.chromium.org/2632223002/diff/40001/tools/foozzie/v8_suppressions.py#newcode55 tools/foozzie/v8_suppressions.py:55: lol, overwriting a dict key. oh well, will come ...
3 years, 11 months ago (2017-01-18 10:35:29 UTC) #9
bradn
3 years, 11 months ago (2017-01-18 17:05:16 UTC) #11
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698