Grab more fallback crash detail on canary/dev.

Grab more fallback crash detail on canary/dev.

BUG=678959
Review-Url: https://codereview.chromium.org/2632123007
Cr-Commit-Position: refs/heads/master@{#444097}
Committed: https://chromium.googlesource.com/chromium/src/+/24b021071bd3cec503565d1df1094e4d49129265

[Sigurður Ásgeirsson, 2017-01-17 17:01:19]

The CQ bit was checked by siggi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-17 17:01:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sigurður Ásgeirsson, 2017-01-17 17:04:46]

Description was changed from

==========
Grab more fallback crash detail on canary/dev.

Grab more fallback crash detail on canary/dev.

BUG=678959
==========

to

==========
Grab more fallback crash detail on canary/dev.

BUG=678959
==========

[Sigurður Ásgeirsson, 2017-01-17 17:04:46]

siggi@chromium.org changed reviewers:
+ jochen@chromium.org, scottmg@chromium.org

[Sigurður Ásgeirsson, 2017-01-17 17:06:52]

Hey guys,

first come, first serve, but I'd love to get this into tomorrow's canary.

The Crashpad crashes I've looked at so far are barfing on a 2M allocation. I'm
assuming there's something degenerate about the crashed client that causes
Crashpad to build a huge in-memory snapshot.

Siggi

[scottmg, 2017-01-17 17:39:49]

lgtm

https://codereview.chromium.org/2632123007/diff/1/components/crash/content/ap...
File components/crash/content/app/fallback_crash_handler_win.cc (right):

https://codereview.chromium.org/2632123007/diff/1/components/crash/content/ap...
components/crash/content/app/fallback_crash_handler_win.cc:445: 
Extra \n here.

[Sigurður Ásgeirsson, 2017-01-17 17:53:19]

Thanks.

https://codereview.chromium.org/2632123007/diff/1/components/crash/content/ap...
File components/crash/content/app/fallback_crash_handler_win.cc (right):

https://codereview.chromium.org/2632123007/diff/1/components/crash/content/ap...
components/crash/content/app/fallback_crash_handler_win.cc:445: 
On 2017/01/17 17:39:48, scottmg wrote:
> Extra \n here.

Done.

[Sigurður Ásgeirsson, 2017-01-17 17:53:23]

The CQ bit was checked by siggi@chromium.org

[Sigurður Ásgeirsson, 2017-01-17 17:53:23]

The patchset sent to the CQ was uploaded after l-g-t-m from scottmg@chromium.org
Link to the patchset: https://codereview.chromium.org/2632123007/#ps20001
(title: "Address Scott's comment.")

[commit-bot: I haz the power, 2017-01-17 17:53:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-17 18:37:04]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484675603480890,
"parent_rev": "11b24cf16bcfe02c4d881af965330ddfe72e7a64", "commit_rev":
"24b021071bd3cec503565d1df1094e4d49129265"}

[commit-bot: I haz the power, 2017-01-17 18:37:36]

Description was changed from

==========
Grab more fallback crash detail on canary/dev.

BUG=678959
==========

to

==========
Grab more fallback crash detail on canary/dev.

BUG=678959

Review-Url: https://codereview.chromium.org/2632123007
Cr-Commit-Position: refs/heads/master@{#444097}
Committed:
https://chromium.googlesource.com/chromium/src/+/24b021071bd3cec503565d1df109...
==========

[commit-bot: I haz the power, 2017-01-17 18:37:37]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/24b021071bd3cec503565d1df109...

[jochen (gone - plz use gerrit), 2017-01-17 18:39:31]

lgtm