Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1239)

Unified Diff: test/cctest/asmjs/test-asm-typer.cc

Issue 2632123006: Reland: [Parse] ParseInfo owns the parsing Zone. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/cctest/asmjs/test-asm-typer.cc
diff --git a/test/cctest/asmjs/test-asm-typer.cc b/test/cctest/asmjs/test-asm-typer.cc
index 892c968d1d3e0ebb48fd036dec23c2aece3e87db..24f8f9b67273d190f73ec496cd052ae4e2675aa5 100644
--- a/test/cctest/asmjs/test-asm-typer.cc
+++ b/test/cctest/asmjs/test-asm-typer.cc
@@ -53,7 +53,7 @@ class AsmTyperHarnessBuilder {
source_code_(
factory_->NewStringFromUtf8(CStrVector(source)).ToHandleChecked()),
script_(factory_->NewScript(source_code_)) {
- ParseInfo info(zone_, script_);
+ ParseInfo info(script_);
marja 2017/01/17 15:39:08 This is a bit weird. We'll create a Zone here, and
rmcilroy 2017/01/19 12:48:29 You are right and this was actually an issue. I re
info.set_allow_lazy_parsing(false);
info.set_toplevel(true);
info.set_ast_value_factory(&ast_value_factory_);

Powered by Google App Engine
This is Rietveld 408576698