Reland: [Parse] ParseInfo owns the parsing Zone.

test/cctest/asmjs/test-asm-typer.cc

 // Copyright 2016 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <cstring>
 #include <functional>
 #include <iostream>
 #include <memory>
 
 #include "src/asmjs/asm-typer.h"
@@ skipping 35 matching lines @@
         validation_type_(type),
         handles_(),
         zone_(handles_.main_zone()),
         isolate_(CcTest::i_isolate()),
         ast_value_factory_(zone_, isolate_->ast_string_constants(),
                            isolate_->heap()->HashSeed()),
         factory_(isolate_->factory()),
         source_code_(
             factory_->NewStringFromUtf8(CStrVector(source)).ToHandleChecked()),
         script_(factory_->NewScript(source_code_)) {
-    ParseInfo info(zone_, script_);
+    ParseInfo info(script_);

[marja, 2017/01/17 15:39:08]

This is a bit weird. We'll create a Zone here, and ParseInfo will create another
one. And we give ParseInfo an AstValueFactory which is from a different Zone...

But that should work anyway, right?

[rmcilroy, 2017/01/19 12:48:29]

You are right and this was actually an issue. I reworked this test code so that
we use the zone from ParseInfo to create the ast-value-factory.

     info.set_allow_lazy_parsing(false);
     info.set_toplevel(true);
     info.set_ast_value_factory(&ast_value_factory_);
     info.set_ast_value_factory_owned(false);
     Parser parser(&info);
 
     if (!Compiler::ParseAndAnalyze(&info)) {
       std::cerr << "Failed to parse:\n" << source_ << "\n";
       CHECK(false);
     }
@@ skipping 2010 matching lines @@
     if (!ValidationOf(Module(kTests[ii]))
              ->FailsWithMessage(
                  "Constant in return must be signed, float, or double.")) {
       std::cerr << "Test:\n" << kTests[ii];
       CHECK(false);
     }
   }
 }
 
 }  // namespace