gn: fix build with GCC 5

gn: fix build with GCC 5

Technically, this code is correct, but practically a problem as it
makes it hard to read and comprehend for people that have not
completely memorised the C++ standard and its scoping rules.

It also triggers a compiler bug in GCC 5.

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=54430
https://bugs.gentoo.org/show_bug.cgi?id=605828

tools/gn/xcode_writer.cc:173:29: error: use of ‘target’ before deduction of ‘auto’
   for (const auto& target : target->public_deps()) {

Review-Url: https://codereview.chromium.org/2632113003
Cr-Commit-Position: refs/heads/master@{#444083}
Committed: https://chromium.googlesource.com/chromium/src/+/6d75d94d4a41eab2f2963e5ae0cdc0cfad4706c9

[Mike Gilbert, 2017-01-16 22:19:59]

Description was changed from

==========
gn: fix build with GCC 5

Technically, this code is correct, but practically a problem as it
makes it hard to read and comprehend for people that have not
completely memorised the C++ standard and its scoping rules.

It also triggers a compiler bug in GCC 5.

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=54430
https://bugs.gentoo.org/show_bug.cgi?id=605828

tools/gn/xcode_writer.cc:173:29: error: use of ‘target’ before deduction of
‘auto’
   for (const auto& target : target->public_deps()) {
==========

to

==========
gn: fix build with GCC 5

Technically, this code is correct, but practically a problem as it
makes it hard to read and comprehend for people that have not
completely memorised the C++ standard and its scoping rules.

It also triggers a compiler bug in GCC 5.

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=54430
https://bugs.gentoo.org/show_bug.cgi?id=605828

tools/gn/xcode_writer.cc:173:29: error: use of ‘target’ before deduction of
‘auto’
   for (const auto& target : target->public_deps()) {
==========

[Mike Gilbert, 2017-01-16 22:19:59]

floppymaster@gmail.com changed reviewers:
+ brettw@chromium.org, liaoyuke@chromium.org

[Mike Gilbert, 2017-01-16 22:20:33]

Please have a look.

[liaoyuke, 2017-01-17 05:02:48]

On 2017/01/16 22:20:33, Mike Gilbert wrote:
> Please have a look.

Thank you for fixing this! lgtm

[Mike Gilbert, 2017-01-17 16:56:07]

I assume I still need an OWNER sign-off for this pretty trivial change?

If so, ping!

[Dirk Pranke, 2017-01-17 17:06:52]

dpranke@chromium.org changed reviewers:
+ dpranke@chromium.org

[Dirk Pranke, 2017-01-17 17:06:53]

lgtm

[Mike Gilbert, 2017-01-17 17:23:38]

The CQ bit was checked by floppymaster@gmail.com

[commit-bot: I haz the power, 2017-01-17 17:23:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-17 17:37:39]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1484673818931370, "parent_rev":
"ab60e9e70f3bbe7d81744d6f299ccdb46110d873", "commit_rev":
"6d75d94d4a41eab2f2963e5ae0cdc0cfad4706c9"}

[commit-bot: I haz the power, 2017-01-17 17:38:11]

Description was changed from

==========
gn: fix build with GCC 5

Technically, this code is correct, but practically a problem as it
makes it hard to read and comprehend for people that have not
completely memorised the C++ standard and its scoping rules.

It also triggers a compiler bug in GCC 5.

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=54430
https://bugs.gentoo.org/show_bug.cgi?id=605828

tools/gn/xcode_writer.cc:173:29: error: use of ‘target’ before deduction of
‘auto’
   for (const auto& target : target->public_deps()) {
==========

to

==========
gn: fix build with GCC 5

Technically, this code is correct, but practically a problem as it
makes it hard to read and comprehend for people that have not
completely memorised the C++ standard and its scoping rules.

It also triggers a compiler bug in GCC 5.

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=54430
https://bugs.gentoo.org/show_bug.cgi?id=605828

tools/gn/xcode_writer.cc:173:29: error: use of ‘target’ before deduction of
‘auto’
   for (const auto& target : target->public_deps()) {

Review-Url: https://codereview.chromium.org/2632113003
Cr-Commit-Position: refs/heads/master@{#444083}
Committed:
https://chromium.googlesource.com/chromium/src/+/6d75d94d4a41eab2f2963e5ae0cd...
==========

[commit-bot: I haz the power, 2017-01-17 17:38:12]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6d75d94d4a41eab2f2963e5ae0cd...