Rename domain_security_preload_generator.

Rename domain_security_preload_generator.

This CL renames the tool and some of its classes for clarity.

  - The tool is renamed to transport_security_state_generator because all
    related code is named similarly. The tool itself also already lives in 
    the net::transport_security_state namespace.

  - HuffmanFrequencyTracker is renamed to HuffmanBuilder which covers
    the functionality in the class a lot better.

  - The DomainSecurityEntry class is renamed to TransportSecurityStateEntry
    in line with the rename of the tool. DomainSecurityEntries is similarly
    renamed to TransportSecurityStateEntries.

  - Adds a comment to the top of the generated file which informs the reader
    that the file is generated by this tool.

This CL only contains renames/moves and no behavioral changes.

BUG=595493
Review-Url: https://codereview.chromium.org/2632073002
Cr-Commit-Position: refs/heads/master@{#446135}
Committed: https://chromium.googlesource.com/chromium/src/+/0827d0b947920ab29833389c2e5402f82a48bfec

[martijnc, 2017-01-17 21:54:49]

Description was changed from

==========
Rename domain_security_preload_generator.

BUG=595493
==========

to

==========
Rename domain_security_preload_generator.

This CL renames the tool and some of its classes for clarity.

  - The tool is renamed to transport_security_state_generator because all
    related code is named similarly. The tool itself also already lives in 
    the net::transport_security_state namespace.

  - HuffmanFrequencyTracker is renamed to HuffmanBuilder which covers
    the functionality in the class a lot better.

  - Renames DomainSecurityEntry to TransportSecurityStateEntry in line with
    the rename of the tool. DomainSecurityEntries is similarly renamed to
    TransportSecurityStateEntries.

  - Adds a comment to the top of the generated file which informs the reader
    that the file is generated by this tool.

  - The build configuration is moved to its own BUILD.gn file.

This CL only contains renames/moves and no behavioral changes.

BUG=595493
==========

[martijnc, 2017-01-17 21:54:49]

martijn@martijnc.be changed reviewers:
+ rsleevi@chromium.org

[martijnc, 2017-01-17 21:55:01]

The CQ bit was checked by martijn@martijnc.be to run a CQ dry run

[commit-bot: I haz the power, 2017-01-17 21:55:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-17 23:18:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-17 23:18:53]

Dry run: This issue passed the CQ dry run.

[martijnc, 2017-01-18 18:31:23]

Description was changed from

==========
Rename domain_security_preload_generator.

This CL renames the tool and some of its classes for clarity.

  - The tool is renamed to transport_security_state_generator because all
    related code is named similarly. The tool itself also already lives in 
    the net::transport_security_state namespace.

  - HuffmanFrequencyTracker is renamed to HuffmanBuilder which covers
    the functionality in the class a lot better.

  - Renames DomainSecurityEntry to TransportSecurityStateEntry in line with
    the rename of the tool. DomainSecurityEntries is similarly renamed to
    TransportSecurityStateEntries.

  - Adds a comment to the top of the generated file which informs the reader
    that the file is generated by this tool.

  - The build configuration is moved to its own BUILD.gn file.

This CL only contains renames/moves and no behavioral changes.

BUG=595493
==========

to

==========
Rename domain_security_preload_generator.

This CL renames the tool and some of its classes for clarity.

  - The tool is renamed to transport_security_state_generator because all
    related code is named similarly. The tool itself also already lives in 
    the net::transport_security_state namespace.

  - HuffmanFrequencyTracker is renamed to HuffmanBuilder which covers
    the functionality in the class a lot better.

  - The DomainSecurityEntry class is renamed to TransportSecurityStateEntry
    in line with the rename of the tool. DomainSecurityEntries is similarly
    renamed to TransportSecurityStateEntries.

  - Adds a comment to the top of the generated file which informs the reader
    that the file is generated by this tool.

  - The build configuration is moved to its own BUILD.gn file.

This CL only contains renames/moves and no behavioral changes.

BUG=595493
==========

[martijnc, 2017-01-18 18:31:34]

The CQ bit was checked by martijn@martijnc.be to run a CQ dry run

[commit-bot: I haz the power, 2017-01-18 18:32:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[martijnc, 2017-01-18 18:34:04]

Patchset #1 (id:1) has been deleted

[martijnc, 2017-01-18 18:34:44]

Description was changed from

==========
Rename domain_security_preload_generator.

This CL renames the tool and some of its classes for clarity.

  - The tool is renamed to transport_security_state_generator because all
    related code is named similarly. The tool itself also already lives in 
    the net::transport_security_state namespace.

  - HuffmanFrequencyTracker is renamed to HuffmanBuilder which covers
    the functionality in the class a lot better.

  - The DomainSecurityEntry class is renamed to TransportSecurityStateEntry
    in line with the rename of the tool. DomainSecurityEntries is similarly
    renamed to TransportSecurityStateEntries.

  - Adds a comment to the top of the generated file which informs the reader
    that the file is generated by this tool.

  - The build configuration is moved to its own BUILD.gn file.

This CL only contains renames/moves and no behavioral changes.

BUG=595493
==========

to

==========
Rename domain_security_preload_generator.

This CL renames the tool and some of its classes for clarity.

  - The tool is renamed to transport_security_state_generator because all
    related code is named similarly. The tool itself also already lives in 
    the net::transport_security_state namespace.

  - HuffmanFrequencyTracker is renamed to HuffmanBuilder which covers
    the functionality in the class a lot better.

  - The DomainSecurityEntry class is renamed to TransportSecurityStateEntry
    in line with the rename of the tool. DomainSecurityEntries is similarly
    renamed to TransportSecurityStateEntries.

  - Adds a comment to the top of the generated file which informs the reader
    that the file is generated by this tool.

This CL only contains renames/moves and no behavioral changes.

BUG=595493
==========

[martijnc, 2017-01-18 18:51:36]

While writing tests for this I noticed some of these had ended up with
unfortunate names. I think these renames make sense and express the intent/goal
of the code better.

What do you think?

[commit-bot: I haz the power, 2017-01-18 19:27:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-18 19:27:47]

Dry run: This issue passed the CQ dry run.

[Ryan Sleevi, 2017-01-25 18:15:41]

Hey, sorry for the delay, was out sick last week :)

One nit about a comment wrap and it LGTM :)

https://codereview.chromium.org/2632073002/diff/20001/net/tools/transport_sec...
File
net/tools/transport_security_state_generator/transport_security_state_entry.h
(right):

https://codereview.chromium.org/2632073002/diff/20001/net/tools/transport_sec...
net/tools/transport_security_state_generator/transport_security_state_entry.h:46:
// hostname for that entry. This is used to construct the trie.
nit: comment is wrapped badly

[martijnc, 2017-01-25 19:14:52]

The CQ bit was checked by martijn@martijnc.be to run a CQ dry run

[commit-bot: I haz the power, 2017-01-25 19:15:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-25 21:49:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-25 21:49:31]

Dry run: This issue passed the CQ dry run.

[martijnc, 2017-01-25 21:52:55]

The CQ bit was checked by martijn@martijnc.be

[martijnc, 2017-01-25 21:52:56]

Thank you!

https://codereview.chromium.org/2632073002/diff/20001/net/tools/transport_sec...
File
net/tools/transport_security_state_generator/transport_security_state_entry.h
(right):

https://codereview.chromium.org/2632073002/diff/20001/net/tools/transport_sec...
net/tools/transport_security_state_generator/transport_security_state_entry.h:46:
// hostname for that entry. This is used to construct the trie.
On 2017/01/25 at 18:15:41, Ryan Sleevi wrote:
> nit: comment is wrapped badly

Fixed.

[martijnc, 2017-01-25 21:52:56]

The patchset sent to the CQ was uploaded after l-g-t-m from rsleevi@chromium.org
Link to the patchset: https://codereview.chromium.org/2632073002/#ps40001
(title: "rebase & comment rsleevi")

[commit-bot: I haz the power, 2017-01-25 21:53:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-25 22:01:13]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1485381175131290,
"parent_rev": "cc933ae6d6a44d3827aae9d2009336f56e245190", "commit_rev":
"0827d0b947920ab29833389c2e5402f82a48bfec"}

[commit-bot: I haz the power, 2017-01-25 22:01:47]

Description was changed from

==========
Rename domain_security_preload_generator.

This CL renames the tool and some of its classes for clarity.

  - The tool is renamed to transport_security_state_generator because all
    related code is named similarly. The tool itself also already lives in 
    the net::transport_security_state namespace.

  - HuffmanFrequencyTracker is renamed to HuffmanBuilder which covers
    the functionality in the class a lot better.

  - The DomainSecurityEntry class is renamed to TransportSecurityStateEntry
    in line with the rename of the tool. DomainSecurityEntries is similarly
    renamed to TransportSecurityStateEntries.

  - Adds a comment to the top of the generated file which informs the reader
    that the file is generated by this tool.

This CL only contains renames/moves and no behavioral changes.

BUG=595493
==========

to

==========
Rename domain_security_preload_generator.

This CL renames the tool and some of its classes for clarity.

  - The tool is renamed to transport_security_state_generator because all
    related code is named similarly. The tool itself also already lives in 
    the net::transport_security_state namespace.

  - HuffmanFrequencyTracker is renamed to HuffmanBuilder which covers
    the functionality in the class a lot better.

  - The DomainSecurityEntry class is renamed to TransportSecurityStateEntry
    in line with the rename of the tool. DomainSecurityEntries is similarly
    renamed to TransportSecurityStateEntries.

  - Adds a comment to the top of the generated file which informs the reader
    that the file is generated by this tool.

This CL only contains renames/moves and no behavioral changes.

BUG=595493

Review-Url: https://codereview.chromium.org/2632073002
Cr-Commit-Position: refs/heads/master@{#446135}
Committed:
https://chromium.googlesource.com/chromium/src/+/0827d0b947920ab29833389c2e54...
==========

[commit-bot: I haz the power, 2017-01-25 22:01:48]

Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/0827d0b947920ab29833389c2e54...