LayoutTests/fast/multicol/widows2.html - Issue 263203003: [New Multicolumn] Guard against zero or negative space shortage.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/multicol/widows2.html

Issue 263203003: [New Multicolumn] Guard against zero or negative space shortage. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Code review. Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: LayoutTests/fast/multicol/widows2.html

diff --git a/LayoutTests/fast/multicol/widows2.html b/LayoutTests/fast/multicol/widows2.html

new file mode 100644

index 0000000000000000000000000000000000000000..d7e5ce3f742cea11e1030db8a3ea8ef0f5074dcd

--- /dev/null

+++ b/LayoutTests/fast/multicol/widows2.html

@@ -0,0 +1,30 @@

+<!DOCTYPE html>

+<script src="../../resources/js-test.js"></script>

+<script>

+ if (window.internals)

+ internals.settings.setRegionBasedColumnsEnabled(true);

+</script>

Julien - ping for review 2014/05/07 01:12:07 Description of the test?

mstensho (USE GERRIT) 2014/05/07 07:33:40 Done.

+<p>There should be 6 lines in the first column, 5 in the second and 5 in the last one.</p>

+<div id="mc" style="-webkit-columns:3; columns:3; -webkit-column-rule:solid; line-height:50px;">

Julien - ping for review 2014/05/07 01:12:07 Do we need to use the prefixed properties?

mstensho (USE GERRIT) 2014/05/07 07:33:40 Yes, that's the only thing Blink supports. Should

+ <div style="orphans:1; widows:5;">

Julien - ping for review 2014/05/07 01:12:07 It seems like we don't use the orphan rule so coul

mstensho (USE GERRIT) 2014/05/07 07:33:40 According to the spec (CSS 2.1), the initial value

+ line<br>

+ </div>

+</div>

+<script>

+ shouldBe("mc.offsetHeight", "300");

+</script>

« no previous file with comments | « LayoutTests/fast/multicol/widows-expected.txt ('k') | LayoutTests/fast/multicol/widows2-expected.txt » ('j') | no next file with comments »