Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issue 2631803002: MD Settings People: Display "On - custom settings" for custom data types (Closed)

Created:
3 years, 11 months ago by tommycli
Modified:
3 years, 11 months ago
Reviewers:
Nicolas Zea
CC:
chromium-reviews, sync-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings People: Display "On - custom settings" for custom data types When the user has a custom data types synced, display "On - custom settings" instead of "On - sync everything". BUG=662025 Review-Url: https://codereview.chromium.org/2631803002 Cr-Commit-Position: refs/heads/master@{#444409} Committed: https://chromium.googlesource.com/chromium/src/+/634697b5871cac5bee8850a965b97e23961fd8c8

Patch Set 1 #

Total comments: 2

Patch Set 2 : rename var #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -8 lines) Patch
M chrome/app/generated_resources.grd View 1 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/sync/sync_ui_util.cc View 1 5 chunks +16 lines, -7 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
tommycli
zea: PTAL
3 years, 11 months ago (2017-01-13 20:32:56 UTC) #2
Nicolas Zea
lgtm https://codereview.chromium.org/2631803002/diff/1/chrome/browser/sync/sync_ui_util.cc File chrome/browser/sync/sync_ui_util.cc (right): https://codereview.chromium.org/2631803002/diff/1/chrome/browser/sync/sync_ui_util.cc#newcode71 chrome/browser/sync/sync_ui_util.cc:71: bool all_data_types_synced) { nit: for consistency sake, maybe ...
3 years, 11 months ago (2017-01-18 01:15:46 UTC) #3
tommycli
thanks! https://codereview.chromium.org/2631803002/diff/1/chrome/browser/sync/sync_ui_util.cc File chrome/browser/sync/sync_ui_util.cc (right): https://codereview.chromium.org/2631803002/diff/1/chrome/browser/sync/sync_ui_util.cc#newcode71 chrome/browser/sync/sync_ui_util.cc:71: bool all_data_types_synced) { On 2017/01/18 01:15:45, Nicolas Zea ...
3 years, 11 months ago (2017-01-18 16:36:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2631803002/20001
3 years, 11 months ago (2017-01-18 16:36:36 UTC) #7
commit-bot: I haz the power
3 years, 11 months ago (2017-01-18 17:25:38 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/634697b5871cac5bee8850a965b9...

Powered by Google App Engine
This is Rietveld 408576698