MD Settings People: Display "On - custom settings" for custom data types

MD Settings People: Display "On - custom settings" for custom data types

When the user has a custom data types synced, display
"On - custom settings" instead of "On - sync everything".

BUG=662025
Review-Url: https://codereview.chromium.org/2631803002
Cr-Commit-Position: refs/heads/master@{#444409}
Committed: https://chromium.googlesource.com/chromium/src/+/634697b5871cac5bee8850a965b97e23961fd8c8

[tommycli, 2017-01-13 20:32:55]

tommycli@chromium.org changed reviewers:
+ zea@chromium.org

[tommycli, 2017-01-13 20:32:56]

zea: PTAL

[Nicolas Zea, 2017-01-18 01:15:46]

lgtm

https://codereview.chromium.org/2631803002/diff/1/chrome/browser/sync/sync_ui...
File chrome/browser/sync/sync_ui_util.cc (right):

https://codereview.chromium.org/2631803002/diff/1/chrome/browser/sync/sync_ui...
chrome/browser/sync/sync_ui_util.cc:71: bool all_data_types_synced) {
nit: for consistency sake, maybe rename to sync_everything (here and elsewhere)?

[tommycli, 2017-01-18 16:36:09]

thanks!

https://codereview.chromium.org/2631803002/diff/1/chrome/browser/sync/sync_ui...
File chrome/browser/sync/sync_ui_util.cc (right):

https://codereview.chromium.org/2631803002/diff/1/chrome/browser/sync/sync_ui...
chrome/browser/sync/sync_ui_util.cc:71: bool all_data_types_synced) {
On 2017/01/18 01:15:45, Nicolas Zea wrote:
> nit: for consistency sake, maybe rename to sync_everything (here and
elsewhere)?

Done.

[tommycli, 2017-01-18 16:36:12]

The CQ bit was checked by tommycli@chromium.org

[tommycli, 2017-01-18 16:36:13]

The patchset sent to the CQ was uploaded after l-g-t-m from zea@chromium.org
Link to the patchset: https://codereview.chromium.org/2631803002/#ps20001
(title: "rename var")

[commit-bot: I haz the power, 2017-01-18 16:36:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-18 17:25:03]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484757372746380,
"parent_rev": "14b31c1d972346f44ebbb1604c6f4208f3402d3e", "commit_rev":
"634697b5871cac5bee8850a965b97e23961fd8c8"}

[commit-bot: I haz the power, 2017-01-18 17:25:36]

Description was changed from

==========
MD Settings People: Display "On - custom settings" for custom data types

When the user has a custom data types synced, display
"On - custom settings" instead of "On - sync everything".

BUG=662025
==========

to

==========
MD Settings People: Display "On - custom settings" for custom data types

When the user has a custom data types synced, display
"On - custom settings" instead of "On - sync everything".

BUG=662025

Review-Url: https://codereview.chromium.org/2631803002
Cr-Commit-Position: refs/heads/master@{#444409}
Committed:
https://chromium.googlesource.com/chromium/src/+/634697b5871cac5bee8850a965b9...
==========

[commit-bot: I haz the power, 2017-01-18 17:25:38]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/634697b5871cac5bee8850a965b9...