Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1698)

Issue 2631783004: Remove min fps requirements for VDA unittest on windows bots. (Closed)

Created:
3 years, 11 months ago by jbauman
Modified:
3 years, 10 months ago
CC:
chromium-reviews, jam, darin-cc_chromium.org, piman+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove min fps requirements for VDA unittest on windows bots. These bots can be intermittently slow, so requiring 50 fps isn't possible. This patch specifies in the command-line argument to the test that there's no minimum fps on the test file that's used. The tests will still fail and time out if they take way too long. BUG=680348 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2631783004 Cr-Commit-Position: refs/heads/master@{#450660} Committed: https://chromium.googlesource.com/chromium/src/+/b3fdd063a1128b441a232215a5798416c3b63ef4

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -16 lines) Patch
M content/test/gpu/generate_buildbot_json.py View 1 1 chunk +1 line, -0 lines 0 comments Download
M testing/buildbot/chromium.gpu.json View 1 2 chunks +4 lines, -2 lines 0 comments Download
M testing/buildbot/chromium.gpu.fyi.json View 1 14 chunks +28 lines, -14 lines 0 comments Download

Messages

Total messages: 23 (15 generated)
jbauman
3 years, 11 months ago (2017-01-17 22:33:49 UTC) #7
Ken Russell (switch to Gerrit)
These bots run only one test at a time. The VDA unittests have full control ...
3 years, 11 months ago (2017-01-17 23:51:46 UTC) #8
jbauman
On 2017/01/17 23:51:46, Ken Russell wrote: > These bots run only one test at a ...
3 years, 10 months ago (2017-02-14 02:21:53 UTC) #10
Ken Russell (switch to Gerrit)
lgtm John, if you can help in diagnosing what might be happening here, we would ...
3 years, 10 months ago (2017-02-14 03:08:58 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2631783004/20001
3 years, 10 months ago (2017-02-15 01:21:53 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/390413)
3 years, 10 months ago (2017-02-15 03:58:24 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2631783004/20001
3 years, 10 months ago (2017-02-15 10:25:03 UTC) #20
commit-bot: I haz the power
3 years, 10 months ago (2017-02-15 11:08:40 UTC) #23
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/b3fdd063a1128b441a232215a579...

Powered by Google App Engine
This is Rietveld 408576698