Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(742)

Issue 2631783003: Revert of Fix touch event flag may not be updated correctly by transform which causes no layout (Closed)

Created:
3 years, 11 months ago by xlai (Olivia)
Modified:
3 years, 11 months ago
Reviewers:
chrishtr, majidvp, yigu
CC:
blink-reviews, blink-reviews-paint_chromium.org, chromium-reviews, dshwang
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix touch event flag may not be updated correctly by transform which causes no layout (patchset #7 id:120001 of https://codereview.chromium.org/2600593002/ ) Reason for revert: Suspecting that this CL is causing failure of fast/events/touch/gesture/pad-gesture-fling.html On WebKit Win7 (dbg) because it is the only CL that modifies touch event. https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20%28dbg%29/builds/8720 Original issue's description: > Fix touch event flag may not be updated correctly by transform which causes no layout > > BUG=673102 > TEST=third_party/WebKit/LayoutTests/fast/events/touch/compositor-touch-hit-rects-geometry-change-as-touch-notified-by-nolayout.html > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > > Review-Url: https://codereview.chromium.org/2600593002 > Cr-Commit-Position: refs/heads/master@{#443580} > Committed: https://chromium.googlesource.com/chromium/src/+/3ad9090bc969c9e2b450ec249d4dfac398bb27b8 TBR=chrishtr@chromium.org,majidvp@chromium.org,yigu@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=673102 Review-Url: https://codereview.chromium.org/2631783003 Cr-Commit-Position: refs/heads/master@{#443650} Committed: https://chromium.googlesource.com/chromium/src/+/4141f530d2d03c42cba3fb5c0949fd33fff0f36f

Patch Set 1 #

Messages

Total messages: 6 (3 generated)
xlai (Olivia)
Created Revert of Fix touch event flag may not be updated correctly by transform which ...
3 years, 11 months ago (2017-01-13 20:33:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2631783003/1
3 years, 11 months ago (2017-01-13 20:34:27 UTC) #3
commit-bot: I haz the power
3 years, 11 months ago (2017-01-13 20:36:00 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4141f530d2d03c42cba3fb5c0949...

Powered by Google App Engine
This is Rietveld 408576698