Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 2631773002: Convert VLOG -> DVLOG in content/browser/bluetooth (Closed)

Created:
3 years, 11 months ago by dougt
Modified:
3 years, 11 months ago
Reviewers:
scheib
CC:
chromium-reviews, jam, ortuno+watch_chromium.org, scheib+watch_chromium.org, darin-cc_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert VLOG -> DVLOG in browser/bluetooth The Chromium C++ style guide recommends that DVLOG is used as it "avoids bloating the release executable and in debug can be selectively enabled at runtime". R=scheib BUG=519010 Review-Url: https://codereview.chromium.org/2631773002 Cr-Commit-Position: refs/heads/master@{#443717} Committed: https://chromium.googlesource.com/chromium/src/+/16af7e87fbb7d49f79185b33209249f4877f8950

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -26 lines) Patch
M content/browser/bluetooth/bluetooth_allowed_devices_map.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/bluetooth/bluetooth_device_chooser_controller.cc View 5 chunks +15 lines, -15 lines 0 comments Download
M content/browser/bluetooth/web_bluetooth_service_impl.cc View 8 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
dougt
dcheng pointed out that we should be using DVLOG in a review of the getDescriptor[s] ...
3 years, 11 months ago (2017-01-13 19:49:11 UTC) #1
scheib
LGTM It may be a tad earlier than we had planned to do this, but ...
3 years, 11 months ago (2017-01-13 20:07:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2631773002/1
3 years, 11 months ago (2017-01-13 20:08:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2631773002/1
3 years, 11 months ago (2017-01-13 21:29:09 UTC) #8
commit-bot: I haz the power
3 years, 11 months ago (2017-01-13 23:20:40 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/16af7e87fbb7d49f79185b332092...

Powered by Google App Engine
This is Rietveld 408576698