Fix ASAN default suppression symbol mangling on windows

Fix ASAN default suppression symbol mangling on windows

I'm working on a patch to fix asan_options on windows and I faced this
two incompatibles symbols:

  00D 00000000 SECT2  notype       External     | ?kASanDefaultSuppressions@@3PADA (char * kASanDefaultSuppressions)
  01F 00000000 UNDEF  notype       External     | _kASanDefaultSuppressions

This is caused by the way the symbols are defined (i.e. extern "C").

src/build/sanitizers/asan_suppressions.cc
  char kASanDefaultSuppressions[] =

src/build/sanitizers/sanitizer_options.cc
  extern "C" char kASanDefaultSuppressions[];


BUG=681027
R=eugenis@chromium.org, chrisha@chromium.com, rnk@chromium.org

Review-Url: https://codereview.chromium.org/2631753002
Cr-Commit-Position: refs/heads/master@{#444764}
Committed: https://chromium.googlesource.com/chromium/src/+/c9e8aae171ee0999ed1ad766089d76cf40159fee

[etienneb, 2017-01-13 19:00:22]

Description was changed from

==========
Fix ASAN default suppression symbol mangling on windows

I'm working on a patch to fix asan_options on windows and I faced this
two incompatibles symbols:

  00D 00000000 SECT2  notype       External     |
?kASanDefaultSuppressions@@3PADA (char * kASanDefaultSuppressions)
  01F 00000000 UNDEF  notype       External     | _kASanDefaultSuppressions

This is caused by the way the symbol is exported (extern "C").


BUG=681027

R=eugenis@chromium.org, chrisha@chromium.com, rnk@chromium.org
==========

to

==========
Fix ASAN default suppression symbol mangling on windows

I'm working on a patch to fix asan_options on windows and I faced this
two incompatibles symbols:

  00D 00000000 SECT2  notype       External     |
?kASanDefaultSuppressions@@3PADA (char * kASanDefaultSuppressions)
  01F 00000000 UNDEF  notype       External     | _kASanDefaultSuppressions

This is caused by the way the symbols are defined (i.e. extern "C").

src/build/sanitizers/asan_suppressions.cc
  char kASanDefaultSuppressions[] =

src/build/sanitizers/sanitizer_options.cc
  extern "C" char kASanDefaultSuppressions[];


BUG=681027

R=eugenis@chromium.org, chrisha@chromium.com, rnk@chromium.org
==========

[etienneb, 2017-01-13 19:00:38]

PTAL.

[Reid Kleckner, 2017-01-13 20:52:43]

https://codereview.chromium.org/2631753002/diff/1/build/sanitizers/sanitizer_...
File build/sanitizers/sanitizer_options.cc (left):

https://codereview.chromium.org/2631753002/diff/1/build/sanitizers/sanitizer_...
build/sanitizers/sanitizer_options.cc:134: extern "C" char
kTSanDefaultSuppressions[];
This has the same issue, it just isn't a problem on Linux because global
variables aren't mangled.

https://codereview.chromium.org/2631753002/diff/1/build/sanitizers/sanitizer_...
build/sanitizers/sanitizer_options.cc:169: extern "C" char
kLSanDefaultSuppressions[];
Ditto

[etienneb, 2017-01-16 16:48:41]

etienneb@chromium.org changed reviewers:
+ chrisha@chromium.org
- chrisha@chromium.com

[etienneb, 2017-01-16 16:49:22]

Thanks rnk@, fixed the other cases.

PTAL.

https://codereview.chromium.org/2631753002/diff/1/build/sanitizers/sanitizer_...
File build/sanitizers/sanitizer_options.cc (left):

https://codereview.chromium.org/2631753002/diff/1/build/sanitizers/sanitizer_...
build/sanitizers/sanitizer_options.cc:134: extern "C" char
kTSanDefaultSuppressions[];
On 2017/01/13 20:52:43, Reid Kleckner wrote:
> This has the same issue, it just isn't a problem on Linux because global
> variables aren't mangled.

Done.

https://codereview.chromium.org/2631753002/diff/1/build/sanitizers/sanitizer_...
build/sanitizers/sanitizer_options.cc:169: extern "C" char
kLSanDefaultSuppressions[];
On 2017/01/13 20:52:43, Reid Kleckner wrote:
> Ditto

Done.

[etienneb, 2017-01-16 20:32:38]

etienneb@chromium.org changed reviewers:
+ glider@chromium.org

[etienneb, 2017-01-16 20:32:55]

PTAL

[Reid Kleckner, 2017-01-17 17:44:06]

The CQ bit was checked by rnk@chromium.org

[Reid Kleckner, 2017-01-17 17:44:07]

lgtm

[commit-bot: I haz the power, 2017-01-17 17:44:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-17 17:52:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-17 17:52:12]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[etienneb, 2017-01-17 17:53:04]

This patch needs an owner approval.

[eugenis, 2017-01-17 19:35:14]

lgtm

[etienneb, 2017-01-17 19:35:53]

The CQ bit was checked by etienneb@chromium.org

[commit-bot: I haz the power, 2017-01-17 19:36:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-17 20:18:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-17 20:18:27]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[etienneb, 2017-01-17 20:34:35]

The CQ bit was checked by etienneb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-17 20:35:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-17 21:24:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-17 21:24:51]

Dry run: This issue passed the CQ dry run.

[etienneb, 2017-01-19 15:28:49]

The CQ bit was checked by etienneb@chromium.org

[etienneb, 2017-01-19 15:28:49]

The patchset sent to the CQ was uploaded after l-g-t-m from rnk@chromium.org,
eugenis@chromium.org
Link to the patchset: https://codereview.chromium.org/2631753002/#ps40001
(title: "fix extern")

[commit-bot: I haz the power, 2017-01-19 15:29:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-19 16:34:56]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1484839729319960,
"parent_rev": "4105bfeb59cd108955521f923dc7731939f07de8", "commit_rev":
"c9e8aae171ee0999ed1ad766089d76cf40159fee"}

[commit-bot: I haz the power, 2017-01-19 16:35:27]

Description was changed from

==========
Fix ASAN default suppression symbol mangling on windows

I'm working on a patch to fix asan_options on windows and I faced this
two incompatibles symbols:

  00D 00000000 SECT2  notype       External     |
?kASanDefaultSuppressions@@3PADA (char * kASanDefaultSuppressions)
  01F 00000000 UNDEF  notype       External     | _kASanDefaultSuppressions

This is caused by the way the symbols are defined (i.e. extern "C").

src/build/sanitizers/asan_suppressions.cc
  char kASanDefaultSuppressions[] =

src/build/sanitizers/sanitizer_options.cc
  extern "C" char kASanDefaultSuppressions[];


BUG=681027

R=eugenis@chromium.org, chrisha@chromium.com, rnk@chromium.org
==========

to

==========
Fix ASAN default suppression symbol mangling on windows

I'm working on a patch to fix asan_options on windows and I faced this
two incompatibles symbols:

  00D 00000000 SECT2  notype       External     |
?kASanDefaultSuppressions@@3PADA (char * kASanDefaultSuppressions)
  01F 00000000 UNDEF  notype       External     | _kASanDefaultSuppressions

This is caused by the way the symbols are defined (i.e. extern "C").

src/build/sanitizers/asan_suppressions.cc
  char kASanDefaultSuppressions[] =

src/build/sanitizers/sanitizer_options.cc
  extern "C" char kASanDefaultSuppressions[];


BUG=681027

R=eugenis@chromium.org, chrisha@chromium.com, rnk@chromium.org

Review-Url: https://codereview.chromium.org/2631753002
Cr-Commit-Position: refs/heads/master@{#444764}
Committed:
https://chromium.googlesource.com/chromium/src/+/c9e8aae171ee0999ed1ad766089d...
==========

[commit-bot: I haz the power, 2017-01-19 16:35:28]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/c9e8aae171ee0999ed1ad766089d...