Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2631713002:
[Android] Raise timeout and required devices for chrome_public_test_apk on L Phone. (Closed)
Description[Android] Raise timeout and required devices for chrome_public_test_apk on L Phone.
BUG=680981
TBR=bpastene@chromium.org
Review-Url: https://codereview.chromium.org/2631713002
Cr-Commit-Position: refs/heads/master@{#443623}
Committed: https://chromium.googlesource.com/chromium/src/+/4c94218865f2cbdabb6ca5991c22b97abab55f16
Patch Set 1 #
Total comments: 2
Messages
Total messages: 16 (7 generated)
TBR
The CQ bit was checked by jbudorick@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by jbudorick@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by jbudorick@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2631713002/diff/1/testing/buildbot/chromium.a... File testing/buildbot/chromium.android.json (right): https://codereview.chromium.org/2631713002/diff/1/testing/buildbot/chromium.a... testing/buildbot/chromium.android.json:2378: "android_devices": "6", This bot runs on a pool of only two swarming bots. If both lose a couple devices, this test will never get picked up. IMO, we should remove the android_devices field for bots running on their own pools. That said, lgtm.
https://codereview.chromium.org/2631713002/diff/1/testing/buildbot/chromium.a... File testing/buildbot/chromium.android.json (right): https://codereview.chromium.org/2631713002/diff/1/testing/buildbot/chromium.a... testing/buildbot/chromium.android.json:2378: "android_devices": "6", On 2017/01/13 17:41:31, bpastene wrote: > This bot runs on a pool of only two swarming bots. If both lose a couple > devices, this test will never get picked up. IMO, we should remove the > android_devices field for bots running on their own pools. That said, lgtm. The alternative is having it get picked up and timing out (though it's not clear that that will happen w/ 1800s vs 960s). Either way, we get an infra error, I suppose.
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1484328132512750, "parent_rev":
"de0a5c0273ea322431f88c0c3dbc333666ae1c30", "commit_rev":
"4c94218865f2cbdabb6ca5991c22b97abab55f16"}
Message was sent while issue was closed.
Description was changed from ========== [Android] Raise timeout and required devices for chrome_public_test_apk on L Phone. BUG=680981 TBR=bpastene@chromium.org ========== to ========== [Android] Raise timeout and required devices for chrome_public_test_apk on L Phone. BUG=680981 TBR=bpastene@chromium.org Review-Url: https://codereview.chromium.org/2631713002 Cr-Commit-Position: refs/heads/master@{#443623} Committed: https://chromium.googlesource.com/chromium/src/+/4c94218865f2cbdabb6ca5991c22... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/4c94218865f2cbdabb6ca5991c22... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
