Make ApplicationCache a DOMWindowClient

Make ApplicationCache a DOMWindowClient

ApplicationCache is a per-DOMWindow thing instead of a per-ExecutionContext thing.
It should use DOMWindowClient instead of ContextClient.

BUG=610176
Review-Url: https://codereview.chromium.org/2631653002
Cr-Commit-Position: refs/heads/master@{#443541}
Committed: https://chromium.googlesource.com/chromium/src/+/989dace104cd4bc1aa304c9c30c54e6cff0d894d

[haraken, 2017-01-13 06:32:55]

haraken@chromium.org changed reviewers:
+ dcheng@chromium.org

[haraken, 2017-01-13 06:32:56]

PTAL

I think this is the last one we should convert to DOMWindowClient.

[dcheng, 2017-01-13 09:14:16]

https://codereview.chromium.org/2631653002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/loader/appcache/ApplicationCache.cpp (left):

https://codereview.chromium.org/2631653002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/loader/appcache/ApplicationCache.cpp:54: if
(ApplicationCacheHost* cacheHost = applicationCacheHost())
How come it's OK to skip this?

[haraken, 2017-01-13 09:18:21]

https://codereview.chromium.org/2631653002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/loader/appcache/ApplicationCache.cpp (left):

https://codereview.chromium.org/2631653002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/loader/appcache/ApplicationCache.cpp:54: if
(ApplicationCacheHost* cacheHost = applicationCacheHost())
On 2017/01/13 09:14:16, dcheng wrote:
> How come it's OK to skip this?

cacheHost->setApplicationCache(0) was called just for making
ApplicationCacheHost::dispatchDOMEvent() return early when the context (<-- this
should be window btw) is detached.

After this CL, it is realized by the '!m_domApplicationCache->domWindow()' check
in ApplicationCacheHost::dispatchDOMEvent().

[dcheng, 2017-01-13 09:22:42]

LGTM

[haraken, 2017-01-13 09:23:20]

The CQ bit was checked by haraken@chromium.org

[commit-bot: I haz the power, 2017-01-13 09:23:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-13 12:41:01]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1484299400547300, "parent_rev":
"71db1d97d86d4bfa89edb4d8b7bbebdecf701b47", "commit_rev":
"989dace104cd4bc1aa304c9c30c54e6cff0d894d"}

[commit-bot: I haz the power, 2017-01-13 12:41:32]

Description was changed from

==========
Make ApplicationCache a DOMWindowClient

ApplicationCache is a per-DOMWindow thing instead of a per-ExecutionContext
thing.
It should use DOMWindowClient instead of ContextClient.

BUG=610176
==========

to

==========
Make ApplicationCache a DOMWindowClient

ApplicationCache is a per-DOMWindow thing instead of a per-ExecutionContext
thing.
It should use DOMWindowClient instead of ContextClient.

BUG=610176

Review-Url: https://codereview.chromium.org/2631653002
Cr-Commit-Position: refs/heads/master@{#443541}
Committed:
https://chromium.googlesource.com/chromium/src/+/989dace104cd4bc1aa304c9c30c5...
==========

[commit-bot: I haz the power, 2017-01-13 12:41:33]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/989dace104cd4bc1aa304c9c30c5...