Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Issue 2631613002: Revert of Add quic_logging (Closed)

Created:
3 years, 11 months ago by mikecase (-- gone --)
Modified:
3 years, 11 months ago
Reviewers:
Ryan Hamilton, Fan Yang
CC:
chromium-reviews, cbentzel+watch_chromium.org, dcheng
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add quic_logging (patchset #9 id:160001 of https://codereview.chromium.org/2611613003/ ) Reason for revert: Sheriff: Suspect CL for causing net_unittest failures on several bots such as https://uberchromegw.corp.google.com/i/chromium.android/builders/Android%20Cronet%20Lollipop%20Builder Original issue's description: > Add quic_logging. > > Merge internal change 143128776 > > BUG= > > Review-Url: https://codereview.chromium.org/2611613003 > Cr-Commit-Position: refs/heads/master@{#443413} > Committed: https://chromium.googlesource.com/chromium/src/+/955b101f8b2f8f1e1db8d80cbac4c3519504ec39 TBR=rch@chromium.org,fayang@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+838 lines, -1005 lines) Patch
M net/net.gypi View 2 chunks +0 lines, -2 lines 0 comments Download
M net/quic/core/congestion_control/bbr_sender.cc View 3 chunks +5 lines, -6 lines 0 comments Download
M net/quic/core/congestion_control/bbr_sender_test.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M net/quic/core/congestion_control/cubic.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M net/quic/core/congestion_control/cubic_bytes.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M net/quic/core/congestion_control/cubic_bytes_test.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/core/congestion_control/cubic_test.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/core/congestion_control/general_loss_algorithm_test.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/core/congestion_control/hybrid_slow_start.cc View 2 chunks +1 line, -3 lines 0 comments Download
M net/quic/core/congestion_control/hybrid_slow_start_test.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/core/congestion_control/pacing_sender.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M net/quic/core/congestion_control/pacing_sender_test.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M net/quic/core/congestion_control/prr_sender_test.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/core/congestion_control/rtt_stats.cc View 3 chunks +5 lines, -8 lines 0 comments Download
M net/quic/core/congestion_control/rtt_stats_test.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/core/congestion_control/send_algorithm_test.cc View 4 chunks +9 lines, -9 lines 0 comments Download
M net/quic/core/congestion_control/tcp_cubic_sender_bytes.cc View 5 chunks +11 lines, -12 lines 0 comments Download
M net/quic/core/congestion_control/tcp_cubic_sender_bytes_test.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M net/quic/core/congestion_control/tcp_cubic_sender_packets.cc View 5 chunks +11 lines, -12 lines 0 comments Download
M net/quic/core/congestion_control/tcp_cubic_sender_packets_test.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M net/quic/core/congestion_control/windowed_filter.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/core/congestion_control/windowed_filter_test.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/core/crypto/aead_base_decrypter.cc View 2 chunks +1 line, -2 lines 0 comments Download
M net/quic/core/crypto/aead_base_encrypter.cc View 2 chunks +1 line, -2 lines 0 comments Download
M net/quic/core/crypto/cert_compressor.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/core/crypto/common_cert_set.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/core/crypto/crypto_framer.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/core/crypto/crypto_framer_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/quic/core/crypto/crypto_utils.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M net/quic/core/crypto/curve25519_key_exchange.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/core/crypto/p256_key_exchange.cc View 7 chunks +10 lines, -10 lines 0 comments Download
M net/quic/core/crypto/quic_compressed_certs_cache_test.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/core/crypto/quic_crypto_client_config.cc View 2 chunks +1 line, -2 lines 0 comments Download
M net/quic/core/crypto/quic_crypto_server_config.cc View 20 chunks +72 lines, -81 lines 0 comments Download
M net/quic/core/crypto/quic_decrypter.cc View 2 chunks +1 line, -2 lines 0 comments Download
M net/quic/core/crypto/quic_encrypter.cc View 2 chunks +1 line, -2 lines 0 comments Download
M net/quic/core/crypto/quic_random.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/core/crypto/strike_register.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/frames/quic_frame.cc View 2 chunks +1 line, -2 lines 0 comments Download
M net/quic/core/frames/quic_stream_frame.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/quic_alarm.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M net/quic/core/quic_alarm_test.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/core/quic_arena_scoped_ptr.h View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/quic_bandwidth.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/core/quic_client_promised_info.cc View 3 chunks +5 lines, -6 lines 0 comments Download
M net/quic/core/quic_client_promised_info_test.cc View 2 chunks +1 line, -2 lines 0 comments Download
M net/quic/core/quic_client_session_base.cc View 5 chunks +7 lines, -8 lines 0 comments Download
M net/quic/core/quic_config.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/quic/core/quic_connection.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/core/quic_connection.cc View 46 chunks +124 lines, -134 lines 0 comments Download
M net/quic/core/quic_connection_test.cc View 2 chunks +1 line, -2 lines 0 comments Download
M net/quic/core/quic_crypto_client_stream.cc View 4 chunks +5 lines, -6 lines 0 comments Download
M net/quic/core/quic_crypto_server_stream.cc View 5 chunks +15 lines, -17 lines 0 comments Download
M net/quic/core/quic_crypto_server_stream_test.cc View 2 chunks +1 line, -2 lines 0 comments Download
M net/quic/core/quic_crypto_stream.cc View 4 chunks +6 lines, -7 lines 0 comments Download
M net/quic/core/quic_data_writer.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/core/quic_flow_controller.cc View 12 chunks +44 lines, -48 lines 0 comments Download
M net/quic/core/quic_framer.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/core/quic_framer.cc View 23 chunks +32 lines, -42 lines 0 comments Download
M net/quic/core/quic_framer_test.cc View 10 chunks +27 lines, -28 lines 0 comments Download
M net/quic/core/quic_headers_stream_test.cc View 4 chunks +8 lines, -9 lines 0 comments Download
M net/quic/core/quic_packet_creator.cc View 4 chunks +3 lines, -3 lines 0 comments Download
M net/quic/core/quic_packet_generator.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/quic/core/quic_packets.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/core/quic_received_packet_manager.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/core/quic_sent_packet_manager.cc View 5 chunks +9 lines, -9 lines 0 comments Download
M net/quic/core/quic_server_id.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/core/quic_server_session_base.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M net/quic/core/quic_session.cc View 15 chunks +44 lines, -49 lines 0 comments Download
M net/quic/core/quic_spdy_session.cc View 7 chunks +13 lines, -14 lines 0 comments Download
M net/quic/core/quic_spdy_stream.cc View 6 chunks +8 lines, -8 lines 0 comments Download
M net/quic/core/quic_stream.cc View 9 chunks +13 lines, -16 lines 0 comments Download
M net/quic/core/quic_stream_sequencer.cc View 5 chunks +9 lines, -9 lines 0 comments Download
M net/quic/core/quic_stream_sequencer_buffer.cc View 9 chunks +17 lines, -19 lines 0 comments Download
M net/quic/core/quic_stream_sequencer_buffer_test.cc View 9 chunks +17 lines, -19 lines 0 comments Download
M net/quic/core/quic_stream_sequencer_test.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M net/quic/core/quic_stream_test.cc View 2 chunks +1 line, -2 lines 0 comments Download
M net/quic/core/quic_sustained_bandwidth_recorder.h View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/quic_sustained_bandwidth_recorder.cc View 4 chunks +7 lines, -8 lines 0 comments Download
M net/quic/core/quic_time.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/core/quic_unacked_packet_map.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/core/quic_versions.cc View 3 chunks +2 lines, -4 lines 0 comments Download
M net/quic/core/spdy_utils.cc View 10 chunks +20 lines, -26 lines 0 comments Download
D net/quic/platform/api/quic_logging.h View 1 chunk +0 lines, -23 lines 0 comments Download
M net/quic/platform/impl/quic_bug_tracker_impl.h View 1 chunk +8 lines, -10 lines 0 comments Download
D net/quic/platform/impl/quic_logging_impl.h View 1 chunk +0 lines, -47 lines 0 comments Download
M net/quic/test_tools/crypto_test_utils.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/test_tools/crypto_test_utils.cc View 4 chunks +11 lines, -14 lines 0 comments Download
M net/quic/test_tools/fake_proof_source.cc View 3 chunks +2 lines, -3 lines 0 comments Download
M net/quic/test_tools/quic_stream_sequencer_buffer_peer.cc View 2 chunks +7 lines, -8 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.cc View 3 chunks +2 lines, -3 lines 0 comments Download
M net/quic/test_tools/simulator/README.md View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/test_tools/simulator/queue.cc View 2 chunks +5 lines, -6 lines 0 comments Download
M net/quic/test_tools/simulator/simulator.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M net/quic/test_tools/simulator/simulator_test.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M net/tools/quic/end_to_end_test.cc View 12 chunks +20 lines, -24 lines 0 comments Download
M net/tools/quic/platform/impl/quic_socket_utils.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M net/tools/quic/platform/impl/quic_socket_utils_test.cc View 2 chunks +5 lines, -6 lines 0 comments Download
M net/tools/quic/quic_client.cc View 4 chunks +4 lines, -5 lines 0 comments Download
M net/tools/quic/quic_client_base.cc View 4 chunks +4 lines, -5 lines 0 comments Download
M net/tools/quic/quic_client_bin.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/tools/quic/quic_client_session.cc View 3 chunks +9 lines, -9 lines 0 comments Download
M net/tools/quic/quic_dispatcher.cc View 8 chunks +11 lines, -13 lines 0 comments Download
M net/tools/quic/quic_dispatcher_test.cc View 4 chunks +4 lines, -5 lines 0 comments Download
M net/tools/quic/quic_epoll_alarm_factory.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/tools/quic/quic_epoll_connection_helper.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/tools/quic/quic_http_response_cache.cc View 9 chunks +16 lines, -19 lines 0 comments Download
M net/tools/quic/quic_packet_reader.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/tools/quic/quic_server.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M net/tools/quic/quic_server_test.cc View 3 chunks +2 lines, -3 lines 0 comments Download
M net/tools/quic/quic_simple_server_session.cc View 4 chunks +5 lines, -6 lines 0 comments Download
M net/tools/quic/quic_simple_server_stream.cc View 13 chunks +30 lines, -33 lines 0 comments Download
M net/tools/quic/quic_spdy_client_stream.cc View 6 chunks +13 lines, -14 lines 0 comments Download
M net/tools/quic/quic_spdy_client_stream_test.cc View 2 chunks +1 line, -2 lines 0 comments Download
M net/tools/quic/quic_spdy_server_stream_base.cc View 2 chunks +1 line, -2 lines 0 comments Download
M net/tools/quic/quic_time_wait_list_manager.cc View 6 chunks +8 lines, -11 lines 0 comments Download
M net/tools/quic/stateless_rejector_test.cc View 2 chunks +1 line, -2 lines 0 comments Download
M net/tools/quic/test_tools/packet_dropping_test_writer.cc View 6 chunks +10 lines, -11 lines 0 comments Download
M net/tools/quic/test_tools/quic_test_client.cc View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
mikecase (-- gone --)
Created Revert of Add quic_logging
3 years, 11 months ago (2017-01-13 02:24:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2631613002/1
3 years, 11 months ago (2017-01-13 02:25:39 UTC) #3
commit-bot: I haz the power
Failed to apply patch for net/net.gypi: While running git apply --index -p1; error: patch failed: ...
3 years, 11 months ago (2017-01-13 02:29:23 UTC) #5
Fan Yang
3 years, 11 months ago (2017-01-13 14:41:45 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2622073007/ by fayang@chromium.org.

The reason for reverting is: Roll forward quic_logging change with fix of failed
unittest..

Powered by Google App Engine
This is Rietveld 408576698