Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1256)

Unified Diff: content/browser/frame_host/navigator.h

Issue 26316005: Move out DidStartProvisionalLoad from WebContentsImpl into Navigator. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Some cleanup. Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/navigator.h
diff --git a/content/browser/frame_host/navigator.h b/content/browser/frame_host/navigator.h
index c20c9dd9c1bf437b2672c6ed449bdbb19c46553a..24b55dbcbeb364d77fa7ed3c250ceb35eb7b68bc 100644
--- a/content/browser/frame_host/navigator.h
+++ b/content/browser/frame_host/navigator.h
@@ -8,10 +8,13 @@
#include "base/memory/ref_counted.h"
#include "content/common/content_export.h"
+class GURL;
+
namespace content {
class NavigationControllerImpl;
class NavigatorDelegate;
+class RenderFrameHostImpl;
// This class is responsible for performing navigations in a node of the
// FrameTree. Its lifetime is bound to all FrameTreeNode objects that are
@@ -33,6 +36,16 @@ class CONTENT_EXPORT Navigator : public base::RefCounted<Navigator> {
return delegate_;
}
+ // The RenderFrameHost started a provisional load.
+ // TODO(nasko): The RenderFrameHost parameter should be replaced with
Charlie Reis 2013/11/21 21:59:32 nit: RenderFrameHostImpl Actually, I'm not sure I
nasko 2013/11/22 01:02:34 The reason for the TODO is previous discussions ab
+ // FrameTreeNode, once we have RenderFrameHostManager for each node in the
Charlie Reis 2013/11/21 21:59:32 nit: have a
nasko 2013/11/22 01:02:34 Done.
+ // frame tree.
Charlie Reis 2013/11/21 21:59:32 nit: FrameTree.
nasko 2013/11/22 01:02:34 Done.
+ void DidStartProvisionalLoad(RenderFrameHostImpl* render_frame_host,
+ int64 frame_id,
+ int64 parent_frame_id,
+ bool main_frame,
+ const GURL& url);
+
private:
friend class base::RefCounted<Navigator>;
virtual ~Navigator() {}

Powered by Google App Engine
This is Rietveld 408576698