Move out DidStartProvisionalLoad from WebContentsImpl into Navigator.

content/browser/frame_host/navigator.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_H_
 #define CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_H_
 
 #include "base/memory/ref_counted.h"
 #include "content/common/content_export.h"
 
+class GURL;
+
 namespace content {
 
 class NavigationControllerImpl;
 class NavigatorDelegate;
+class RenderFrameHostImpl;
 
 // This class is responsible for performing navigations in a node of the
 // FrameTree. Its lifetime is bound to all FrameTreeNode objects that are
 // using it and will be released once all nodes that use it are freed.
 // The Navigator is bound to a single frame tree and cannot be used by multiple
 // instances of FrameTree.
 // TODO(nasko): Move all navigation methods, such as didStartProvisionalLoad
 // from WebContentsImpl to this class.
 class CONTENT_EXPORT Navigator : public base::RefCounted<Navigator> {
  public:
   Navigator(NavigationControllerImpl* nav_controller,
             NavigatorDelegate* delegate);
 
   NavigationControllerImpl* controller() {
     return controller_;
   }
 
   NavigatorDelegate* delegate() {
     return delegate_;
   }
 
+  // The RenderFrameHost started a provisional load.
+  // TODO(nasko): The RenderFrameHost parameter should be replaced with

[Charlie Reis, 2013/11/21 21:59:32]

nit: RenderFrameHostImpl

Actually, I'm not sure I agree with this TODO.  We'll need to know which
RenderFrameHostImpl sent the message even when we have a RFHM on each node, in
case there's a race and the message didn't come from our current RFH.  I think
we have to stick with this contract.

[nasko, 2013/11/22 01:02:34]

The reason for the TODO is previous discussions about structuring the API to
look like navigator->NavigateAt(FrameTreeNode). I'm happy to drop it, since you
make a good point about the possibility of race conditions, which means we need
to either pass RFH or FTN+routing id. We can make this decision as we come
closer to the final picture we want.

+  // FrameTreeNode, once we have RenderFrameHostManager for each node in the

[Charlie Reis, 2013/11/21 21:59:32]

nit: have a

[nasko, 2013/11/22 01:02:34]

Done.

+  // frame tree.

[Charlie Reis, 2013/11/21 21:59:32]

nit: FrameTree.

[nasko, 2013/11/22 01:02:34]

Done.

+  void DidStartProvisionalLoad(RenderFrameHostImpl* render_frame_host,
+                               int64 frame_id,
+                               int64 parent_frame_id,
+                               bool main_frame,
+                               const GURL& url);
+
  private:
   friend class base::RefCounted<Navigator>;
   virtual ~Navigator() {}
 
   // The NavigationController that will keep track of session history for all
   // RenderFrameHost objects using this Navigator.
   // TODO(nasko): Move ownership of the NavigationController from
   // WebContentsImpl to this class.
   NavigationControllerImpl* controller_;
 
   // Used to notify the object embedding this Navigator about navigation
   // events. Can be NULL in tests.
   NavigatorDelegate* delegate_;
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_H_