Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(413)

Issue 2631563002: Enable nav timing 2 by flipping the flag to stable. (Closed)

Created:
3 years, 11 months ago by sunjian
Modified:
3 years, 11 months ago
Reviewers:
tkent, panicker
CC:
chromium-reviews, blink-reviews, kinuko+watch, haraken
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : edited expected files #

Messages

Total messages: 26 (15 generated)
sunjian
3 years, 11 months ago (2017-01-12 22:18:44 UTC) #3
panicker
LGTM. Please update CL description with link to Intent to Ship thread
3 years, 11 months ago (2017-01-13 19:07:48 UTC) #4
panicker
3 years, 11 months ago (2017-01-13 19:08:39 UTC) #6
sunjian
On 2017/01/13 19:07:48, panicker wrote: > LGTM. > Please update CL description with link to ...
3 years, 11 months ago (2017-01-13 19:57:05 UTC) #8
haraken
This will need an API owner review.
3 years, 11 months ago (2017-01-16 00:57:49 UTC) #12
tkent
lgtm, however please write what feature will be enabled in the first line of the ...
3 years, 11 months ago (2017-01-16 01:09:56 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2631563002/1
3 years, 11 months ago (2017-01-17 19:21:22 UTC) #16
panicker
Thanks for the review.
3 years, 11 months ago (2017-01-17 19:21:35 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/370284)
3 years, 11 months ago (2017-01-17 21:08:34 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2631563002/20001
3 years, 11 months ago (2017-01-17 21:38:26 UTC) #23
commit-bot: I haz the power
3 years, 11 months ago (2017-01-17 23:41:12 UTC) #26
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/c57056f952be49a70ab1ceb9f085...

Powered by Google App Engine
This is Rietveld 408576698