Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2631533002:
[M56] Add debug aliases for state_ and urls to debug CHECK failures (Closed)
|
Created:
3 years, 11 months ago by vakh (use Gerrit instead) Modified:
3 years, 11 months ago Reviewers:
Charlie Harrison CC:
chromium-reviews, loading-reviews_chromium.org, Randy Smith (Not in Mondays), mmenke, Nathan Parker Target Ref:
refs/pending/branch-heads/2924 Project:
chromium Visibility:
Public. |
Description[M56] Add debug aliases for state_ and urls to debug CHECK failures
Merges http://crrev.com/2542373002 to M56.
[Merge CL 1/n]
NOTRY=true
NOPRESUBMIT=true
BUG=660293
Review-Url: https://codereview.chromium.org/2631533002
Cr-Commit-Position: refs/branch-heads/2924@{#742}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Committed: https://chromium.googlesource.com/chromium/src/+/ba329014506c5346974f7c7ceab231a8174f1c1c
Patch Set 1 #
Total comments: 3
Patch Set 2 : git pull #
Messages
Total messages: 23 (14 generated)
The CQ bit was checked by vakh@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for the CQ to process them
vakh@chromium.org changed reviewers: + csharrison@chromium.org
Description was changed from ========== Add debug aliases for state_ and urls to debug CHECK failures Merge of: http://crrev.com/2542373002 BUG=660293 ========== to ========== [M56] Add debug aliases for state_ and urls to debug CHECK failures Merge of: http://crrev.com/2542373002 Merging to M56 Stable. BUG=660293 ==========
https://codereview.chromium.org/2631533002/diff/1/chrome/browser/loader/safe_... File chrome/browser/loader/safe_browsing_resource_throttle.cc (right): https://codereview.chromium.org/2631533002/diff/1/chrome/browser/loader/safe_... chrome/browser/loader/safe_browsing_resource_throttle.cc:246: CHECK(false) << "buf: " << buf; LGTM but I thought that the "<< buf..." args to CHECK were elided in release builds?
Thanks for the quick LGTM. https://codereview.chromium.org/2631533002/diff/1/chrome/browser/loader/safe_... File chrome/browser/loader/safe_browsing_resource_throttle.cc (right): https://codereview.chromium.org/2631533002/diff/1/chrome/browser/loader/safe_... chrome/browser/loader/safe_browsing_resource_throttle.cc:246: CHECK(false) << "buf: " << buf; On 2017/01/12 17:19:20, Charlie Harrison wrote: > LGTM but I thought that the "<< buf..." args to CHECK were elided in release > builds? You are right, they are. I thought it is best to merge as-is without making any changes unless absolutely necessary (not necessary in this case since compiler will do that for us).
Description was changed from ========== [M56] Add debug aliases for state_ and urls to debug CHECK failures Merge of: http://crrev.com/2542373002 Merging to M56 Stable. BUG=660293 ========== to ========== [M56] Add debug aliases for state_ and urls to debug CHECK failures Merges http://crrev.com/2542373002 to M56. [Merge CL 1/n] BUG=660293 ==========
https://codereview.chromium.org/2631533002/diff/1/chrome/browser/loader/safe_... File chrome/browser/loader/safe_browsing_resource_throttle.cc (right): https://codereview.chromium.org/2631533002/diff/1/chrome/browser/loader/safe_... chrome/browser/loader/safe_browsing_resource_throttle.cc:246: CHECK(false) << "buf: " << buf; On 2017/01/12 17:23:02, vakh (Varun Khaneja) wrote: > On 2017/01/12 17:19:20, Charlie Harrison wrote: > > LGTM but I thought that the "<< buf..." args to CHECK were elided in release > > builds? > > You are right, they are. I thought it is best to merge as-is without making any > changes unless absolutely necessary (not necessary in this case since compiler > will do that for us). SGTM, just making sure :)
The CQ bit was checked by vakh@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for the CQ to process them
git pull
Description was changed from ========== [M56] Add debug aliases for state_ and urls to debug CHECK failures Merges http://crrev.com/2542373002 to M56. [Merge CL 1/n] BUG=660293 ========== to ========== [M56] Add debug aliases for state_ and urls to debug CHECK failures Merges http://crrev.com/2542373002 to M56. [Merge CL 1/n] NOTRY=true NOPRESUBMIT=true BUG=660293 ==========
The CQ bit was checked by vakh@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from csharrison@chromium.org Link to the patchset: https://codereview.chromium.org/2631533002/#ps20001 (title: "git pull")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484248639333070,
"parent_rev": "daed763fb238476edad2f6f88601f7fbe8fa513c", "commit_rev":
"ba329014506c5346974f7c7ceab231a8174f1c1c"}
Message was sent while issue was closed.
Description was changed from ========== [M56] Add debug aliases for state_ and urls to debug CHECK failures Merges http://crrev.com/2542373002 to M56. [Merge CL 1/n] NOTRY=true NOPRESUBMIT=true BUG=660293 ========== to ========== [M56] Add debug aliases for state_ and urls to debug CHECK failures Merges http://crrev.com/2542373002 to M56. [Merge CL 1/n] NOTRY=true NOPRESUBMIT=true BUG=660293 Review-Url: https://codereview.chromium.org/2631533002 Cr-Commit-Position: refs/branch-heads/2924@{#742} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} Committed: https://chromium.googlesource.com/chromium/src/+/ba329014506c5346974f7c7ceab2... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/ba329014506c5346974f7c7ceab2... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
