Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Issue 2631513002: [LayoutNG] Make NGLayoutInputNode::AlgorithmForInputNode() more readable. (Closed)

Created:
3 years, 11 months ago by mstensho (USE GERRIT)
Modified:
3 years, 11 months ago
Reviewers:
cbiesinger, atotic, eae
CC:
chromium-reviews, ojan+watch_chromium.org, szager+layoutwatch_chromium.org, glebl+reviews_chromium.org, atotic+reviews_chromium.org, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, zoltan1, jchaffraix+rendering, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[LayoutNG] Make NGLayoutInputNode::AlgorithmForInputNode() more readable. Use early returns and variables to avoid unwanted line breaks in statements. Review-Url: https://codereview.chromium.org/2631513002 Cr-Commit-Position: refs/heads/master@{#443284} Committed: https://chromium.googlesource.com/chromium/src/+/690cb481986ae0d2fc6820098a74086753f90771

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -10 lines) Patch
M third_party/WebKit/Source/core/layout/ng/ng_layout_input_node.cc View 1 chunk +8 lines, -10 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
mstensho (USE GERRIT)
3 years, 11 months ago (2017-01-12 12:30:56 UTC) #6
eae
Nice, LGTM
3 years, 11 months ago (2017-01-12 17:32:19 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2631513002/1
3 years, 11 months ago (2017-01-12 17:33:42 UTC) #9
cbiesinger
lgtm
3 years, 11 months ago (2017-01-12 17:52:25 UTC) #10
commit-bot: I haz the power
3 years, 11 months ago (2017-01-12 17:54:54 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/690cb481986ae0d2fc6820098a74...

Powered by Google App Engine
This is Rietveld 408576698