Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(718)

Issue 2631473002: Fixed text-align keywords in CSSProperties.in. (Closed)

Created:
3 years, 11 months ago by napper
Modified:
3 years, 11 months ago
Reviewers:
sashab
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, chromium-reviews, dglazkov+blink, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixed text-align keywords in CSSProperties.in. Fixed text-align keywords in CSSProperties.in to match the values in CSSValueKeywords.in. This will not actually change the generated values at this time since "webkitLeft", and "-webkit-left" will both result in the enum value "kWebkitLeft" being generated. However, long term it is important that the values exactly match those in CSSValueKeywords.in. BUG=628043 Review-Url: https://codereview.chromium.org/2631473002 Cr-Commit-Position: refs/heads/master@{#443410} Committed: https://chromium.googlesource.com/chromium/src/+/5db4d106559db54bf67baf7dc6cce91b41dca812

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/core/css/CSSProperties.in View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
napper
3 years, 11 months ago (2017-01-12 06:24:59 UTC) #4
sashab
lgtm
3 years, 11 months ago (2017-01-12 22:48:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2631473002/1
3 years, 11 months ago (2017-01-12 22:51:15 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-13 00:29:48 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5db4d106559db54bf67baf7dc6cc...

Powered by Google App Engine
This is Rietveld 408576698