[Mac] Flip toolbar in RTL (reland)

[Mac] Flip toolbar in RTL (reland)

This was reverted due to crbug.com/679174 which is fixed by using the
browser action container view's |animationEndFrame| instead of its
frame when calculating the size of the location bar.

Browser actions will be reordered in a future change.

BUG=648558, 648563, 673362
Review-Url: https://codereview.chromium.org/2607533004
Cr-Commit-Position: refs/heads/master@{#441925}
Committed: https://chromium.googlesource.com/chromium/src/+/8b0fd02afc2107ba123774e0a464a43407a108cf

patch from issue 2607533004 at patchset 80001 (http://crrev.com/2607533004#ps80001)

[lgrey, 2017-01-12 19:44:18]

lgrey@chromium.org changed reviewers:
+ tapted@chromium.org

[lgrey, 2017-01-12 19:44:19]

Trent, PTAL :)

https://codereview.chromium.org/2631463004/diff/1/chrome/browser/ui/cocoa/too...
File chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm (right):

https://codereview.chromium.org/2631463004/diff/1/chrome/browser/ui/cocoa/too...
chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm:855: -
(void)pinLocationBarBeforeBrowserActionsContainerAndAnimate:(BOOL)animate {
The change from the previous CL is here

[tapted, 2017-01-12 19:58:40]

https://codereview.chromium.org/2631463004/diff/1/chrome/browser/ui/cocoa/too...
File chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm (right):

https://codereview.chromium.org/2631463004/diff/1/chrome/browser/ui/cocoa/too...
chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm:864:
NSMaxX([browserActionsContainerView_ animationEndFrame]) +
it's hard to tell what changed -- it's often helpful to upload the old patch in
patchset 1 then do a follow-up upload. I think it's just that this line (and
873) is now using [browserActionsContainerView_ animationEndFrame] rather than
[browserActionsContainerView_ frame], which makes sense. So lgtm if that's all.

[lgrey, 2017-01-12 20:04:22]

Thanks!

https://codereview.chromium.org/2631463004/diff/1/chrome/browser/ui/cocoa/too...
File chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm (right):

https://codereview.chromium.org/2631463004/diff/1/chrome/browser/ui/cocoa/too...
chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm:864:
NSMaxX([browserActionsContainerView_ animationEndFrame]) +
On 2017/01/12 19:58:40, tapted wrote:
> it's hard to tell what changed -- it's often helpful to upload the old patch
in
> patchset 1 then do a follow-up upload. I think it's just that this line (and
> 873) is now using [browserActionsContainerView_ animationEndFrame] rather than
> [browserActionsContainerView_ frame], which makes sense. So lgtm if that's
all.

Yup that's it.

Thanks for the heads up on the patchset trick, I'll do that in the future. Still
getting used to Gerritt :)

[lgrey, 2017-01-12 20:04:30]

The CQ bit was checked by lgrey@chromium.org

[commit-bot: I haz the power, 2017-01-12 20:05:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-12 20:32:26]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1484251470127820, "parent_rev":
"bbf111dec4f3d28741e512c89db1063fb4e60eba", "commit_rev":
"882ccc67f27351913c6ae4384c1a79441e1becea"}

[commit-bot: I haz the power, 2017-01-12 20:41:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-12 20:41:07]

Prior attempt to commit was detected, but we were not able to check whether the
issue was successfully committed. Please check Git history manually and re-check
CQ or close this issue as needed.

[lgrey, 2017-01-12 20:59:38]

The CQ bit was checked by lgrey@chromium.org

[lgrey, 2017-01-12 21:00:09]

The CQ bit was unchecked by lgrey@chromium.org

[lgrey, 2017-01-13 01:39:50]

Description was changed from

==========
[Mac] Flip toolbar in RTL (reland)

This was reverted due to crbug.com/679174 which is fixed by using the
browser action container view's |animationEndFrame| instead of its
frame when calculating the size of the location bar.

Browser actions will be reordered in a future change.

BUG=648558, 648563, 673362

Review-Url: https://codereview.chromium.org/2607533004
Cr-Commit-Position: refs/heads/master@{#441925}
Committed:
https://chromium.googlesource.com/chromium/src/+/8b0fd02afc2107ba123774e0a464...

patch from issue 2607533004 at patchset 80001
(http://crrev.com/2607533004#ps80001)
==========

to

==========
[Mac] Flip toolbar in RTL (reland)

This was reverted due to crbug.com/679174 which is fixed by using the
browser action container view's |animationEndFrame| instead of its
frame when calculating the size of the location bar.

Browser actions will be reordered in a future change.

BUG=648558, 648563, 673362

Review-Url: https://codereview.chromium.org/2607533004
Cr-Commit-Position: refs/heads/master@{#441925}
Committed:
https://chromium.googlesource.com/chromium/src/+/8b0fd02afc2107ba123774e0a464...

patch from issue 2607533004 at patchset 80001
(http://crrev.com/2607533004#ps80001)
==========