[Mac] Flip toolbar in RTL (reland)

chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/extensions/browser_actions_controller.h"
 
 #include <stddef.h>
 
 #include <string>
 #include <utility>
 
 #include "base/macros.h"
 #include "base/strings/sys_string_conversions.h"
 #include "chrome/browser/extensions/extension_message_bubble_controller.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_window.h"
 #import "chrome/browser/ui/cocoa/browser_window_controller.h"
 #import "chrome/browser/ui/cocoa/extensions/browser_action_button.h"
 #import "chrome/browser/ui/cocoa/extensions/browser_actions_container_view.h"
 #import "chrome/browser/ui/cocoa/extensions/extension_popup_controller.h"
 #import "chrome/browser/ui/cocoa/extensions/toolbar_actions_bar_bubble_mac.h"
 #import "chrome/browser/ui/cocoa/image_button_cell.h"
+#import "chrome/browser/ui/cocoa/l10n_util.h"
 #import "chrome/browser/ui/cocoa/menu_button.h"
 #import "chrome/browser/ui/cocoa/toolbar/toolbar_controller.h"
 #include "chrome/browser/ui/extensions/extension_message_bubble_bridge.h"
 #include "chrome/browser/ui/tabs/tab_strip_model.h"
 #include "chrome/browser/ui/toolbar/toolbar_action_view_controller.h"
 #include "chrome/browser/ui/toolbar/toolbar_actions_bar.h"
 #include "chrome/browser/ui/toolbar/toolbar_actions_bar_delegate.h"
 #include "chrome/grit/theme_resources.h"
 #import "third_party/google_toolbox_for_mac/src/AppKit/GTMNSAnimation+Duration.h"
 #include "ui/base/cocoa/appkit_utils.h"
@@ skipping 541 matching lines @@
 - (void)updateButtonPositions {
   for (NSUInteger index = 0; index < [buttons_ count]; ++index) {
     BrowserActionButton* button = [buttons_ objectAtIndex:index];
     NSRect buttonFrame = [self frameForIndex:index];
 
     // If the button is at the proper position (or animating to it), then we
     // don't need to update its position.
     if (NSMinX([button frameAfterAnimation]) == NSMinX(buttonFrame))
       continue;
 
-    // We set the x-origin by calculating the proper distance from the right
-    // edge in the container so that, if the container is animating, the
+    // In LTR, We set the x-origin by calculating the proper distance from the
+    // right edge in the container so that, if the container is animating, the
     // button appears stationary.
-    buttonFrame.origin.x = NSWidth([containerView_ frame]) -
-        (toolbarActionsBar_->GetPreferredSize().width() - NSMinX(buttonFrame));
+    if (!cocoa_l10n_util::ShouldDoExperimentalRTLLayout()) {
+      buttonFrame.origin.x = NSWidth([containerView_ frame]) -
+                             (toolbarActionsBar_->GetPreferredSize().width() -
+                              NSMinX(buttonFrame));
+    }
     [button setFrame:buttonFrame animate:NO];
   }
 }
 
 - (BrowserActionButton*)buttonForId:(const std::string&)id {
   for (BrowserActionButton* button in buttons_.get()) {
     if ([button viewController]->GetId() == id)
       return button;
   }
   return nil;
@@ skipping 177 matching lines @@
     [button setFrame:buttonFrame
              animate:!toolbarActionsBar_->suppress_animation() && !isOverflow_];
   }
 }
 
 - (BOOL)browserActionClicked:(BrowserActionButton*)button {
   return [button viewController]->ExecuteAction(true);
 }
 
 - (void)updateGrippyCursors {
+  BOOL canClose = [self visibleButtonCount] > 0;
+  BOOL canOpen = toolbarActionsBar_->GetIconCount() != [buttons_ count];
   [containerView_
-      setCanDragLeft:toolbarActionsBar_->GetIconCount() != [buttons_ count]];
-  [containerView_ setCanDragRight:[self visibleButtonCount] > 0];
+      setCanDragLeft:cocoa_l10n_util::ShouldDoExperimentalRTLLayout()
+                         ? canClose
+                         : canOpen];
+  [containerView_
+      setCanDragRight:cocoa_l10n_util::ShouldDoExperimentalRTLLayout()
+                          ? canOpen
+                          : canClose];
   [[containerView_ window] invalidateCursorRectsForView:containerView_];
 }
 
 - (ToolbarController*)toolbarController {
   return [[BrowserWindowController browserWindowControllerForWindow:
              browser_->window()->GetNativeWindow()] toolbarController];
 }
 
 - (void)createMessageBubble:
     (std::unique_ptr<ToolbarActionsBarBubbleDelegate>)delegate {
@@ skipping 41 matching lines @@
 }
 
 #pragma mark -
 #pragma mark Testing Methods
 
 - (BrowserActionButton*)buttonWithIndex:(NSUInteger)index {
   return index < [buttons_ count] ? [buttons_ objectAtIndex:index] : nil;
 }
 
 @end