Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 2631413002: Compile quick_view_model with closure compiler v2. (Closed)

Created:
3 years, 11 months ago by oka
Modified:
3 years, 11 months ago
Reviewers:
fukino
CC:
chromium-reviews, yamaguchi+watch_chromium.org, oka+watch_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, jlklein+watch-closure_chromium.org, fukino+watch_chromium.org, vitalyp+closure_chromium.org, dbeam+watch-closure_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Compile quick_view_model with closure compiler v2. BUG=636289 TEST=run_compiler. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2631413002 Cr-Commit-Position: refs/heads/master@{#444029} Committed: https://chromium.googlesource.com/chromium/src/+/f37b6ac09bf51be851835295765e1bb18095abb6

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M ui/file_manager/file_manager/foreground/js/compiled_resources2.gyp View 1 1 chunk +8 lines, -4 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (5 generated)
oka
.
3 years, 11 months ago (2017-01-17 09:48:25 UTC) #2
oka
.
3 years, 11 months ago (2017-01-17 09:54:00 UTC) #3
oka
PTAL.
3 years, 11 months ago (2017-01-17 09:54:02 UTC) #5
oka
PTAL.
3 years, 11 months ago (2017-01-17 09:54:02 UTC) #6
fukino
lgtm
3 years, 11 months ago (2017-01-17 10:10:19 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2631413002/40001
3 years, 11 months ago (2017-01-17 11:18:02 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-17 11:42:34 UTC) #12
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/f37b6ac09bf51be851835295765e...

Powered by Google App Engine
This is Rietveld 408576698