Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Issue 2631313003: [Devtools] Bug fix with url as undefined in blocked requests (Closed)

Created:
3 years, 11 months ago by allada
Modified:
3 years, 11 months ago
Reviewers:
dgozman, luoe, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Devtools] Bug fix with url as undefined in blocked requests This patch fixes a small bug with blocked requests in network panel shoing the blocked requests in console caused by a recent code change of chaning SDK.NetworkRequest.url from getter to function. R=dgozman,luoe,pfeldman BUG=679105, 680054 Review-Url: https://codereview.chromium.org/2631313003 Cr-Commit-Position: refs/heads/master@{#444151} Committed: https://chromium.googlesource.com/chromium/src/+/beffc4fe07d6a0ca0964db6fbd895da77c36d455

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/devtools/front_end/sdk/NetworkManager.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (8 generated)
allada
PTL
3 years, 11 months ago (2017-01-17 19:27:34 UTC) #2
pfeldman
lgtm
3 years, 11 months ago (2017-01-17 19:29:42 UTC) #4
pfeldman
Do we have more of these?
3 years, 11 months ago (2017-01-17 19:29:54 UTC) #5
luoe
I did a manual check through all the ".url" matches and could not find any ...
3 years, 11 months ago (2017-01-17 19:30:51 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2631313003/1
3 years, 11 months ago (2017-01-17 21:23:58 UTC) #10
commit-bot: I haz the power
3 years, 11 months ago (2017-01-17 21:30:12 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/beffc4fe07d6a0ca0964db6fbd89...

Powered by Google App Engine
This is Rietveld 408576698