third_party/WebKit/Source/core/html/HTMLIFrameElement.h - Issue 2631233003: Avoid mutating frame owner when detaching a provisional frame.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLIFrameElement.h

Issue 2631233003: Avoid mutating frame owner when detaching a provisional frame. (Closed)

Patch Set: Fix test to actually test the changed behavior. Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/HTMLIFrameElement.h

diff --git a/third_party/WebKit/Source/core/html/HTMLIFrameElement.h b/third_party/WebKit/Source/core/html/HTMLIFrameElement.h

index c49204af92dc9c9ec43e1902ab33e52a71de885c..51ae060faa6306b585b3fff35a19ac7bb79f37bc 100644

--- a/third_party/WebKit/Source/core/html/HTMLIFrameElement.h

+++ b/third_party/WebKit/Source/core/html/HTMLIFrameElement.h

@@ -73,11 +73,10 @@ class CORE_EXPORT HTMLIFrameElement final

ReferrerPolicy referrerPolicyAttribute() override;

+ // FrameOwner overrides:

bool allowFullscreen() const override { return m_allowFullscreen; }

bool allowPaymentRequest() const override { return m_allowPaymentRequest; }

AtomicString csp() const override { return m_csp; }

const WebVector<WebPermissionType>& delegatedPermissions() const override {

return m_delegatedPermissions;

}