third_party/WebKit/Source/core/html/HTMLIFrameElement.h - Issue 2631233003: Avoid mutating frame owner when detaching a provisional frame.

Side by Side Diff: third_party/WebKit/Source/core/html/HTMLIFrameElement.h

Issue 2631233003: Avoid mutating frame owner when detaching a provisional frame. (Closed)

Patch Set: Fix test to actually test the changed behavior. Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« third_party/WebKit/Source/core/frame/Frame.cpp ('K') | « third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.h ('k') | third_party/WebKit/Source/web/RemoteFrameOwner.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)	2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)

3 * (C) 1999 Antti Koivisto (koivisto@kde.org)	3 * (C) 1999 Antti Koivisto (koivisto@kde.org)

4 * (C) 2000 Simon Hausmann <hausmann@kde.org>	4 * (C) 2000 Simon Hausmann <hausmann@kde.org>

5 * Copyright (C) 2004, 2006, 2008, 2009 Apple Inc. All rights reserved.	5 * Copyright (C) 2004, 2006, 2008, 2009 Apple Inc. All rights reserved.

6 *	6 *

7 * This library is free software; you can redistribute it and/or	7 * This library is free software; you can redistribute it and/or

8 * modify it under the terms of the GNU Library General Public	8 * modify it under the terms of the GNU Library General Public

9 * License as published by the Free Software Foundation; either	9 * License as published by the Free Software Foundation; either

10 * version 2 of the License, or (at your option) any later version.	10 * version 2 of the License, or (at your option) any later version.

(...skipping 55 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
66 LayoutObject* createLayoutObject(const ComputedStyle&) override;	66 LayoutObject* createLayoutObject(const ComputedStyle&) override;

67	67

68 bool loadedNonEmptyDocument() const override {	68 bool loadedNonEmptyDocument() const override {

69 return m_didLoadNonEmptyDocument;	69 return m_didLoadNonEmptyDocument;

70 }	70 }

71 void didLoadNonEmptyDocument() override { m_didLoadNonEmptyDocument = true; }	71 void didLoadNonEmptyDocument() override { m_didLoadNonEmptyDocument = true; }

72 bool isInteractiveContent() const override;	72 bool isInteractiveContent() const override;

73	73

74 ReferrerPolicy referrerPolicyAttribute() override;	74 ReferrerPolicy referrerPolicyAttribute() override;

75	75

	76 // FrameOwner overrides:

76 bool allowFullscreen() const override { return m_allowFullscreen; }	77 bool allowFullscreen() const override { return m_allowFullscreen; }

77 bool allowPaymentRequest() const override { return m_allowPaymentRequest; }	78 bool allowPaymentRequest() const override { return m_allowPaymentRequest; }

78

79 AtomicString csp() const override { return m_csp; }	79 AtomicString csp() const override { return m_csp; }

80

81 const WebVector<WebPermissionType>& delegatedPermissions() const override {	80 const WebVector<WebPermissionType>& delegatedPermissions() const override {

82 return m_delegatedPermissions;	81 return m_delegatedPermissions;

83 }	82 }

84	83

85 bool initializePermissionsAttribute();	84 bool initializePermissionsAttribute();

86	85

87 AtomicString m_name;	86 AtomicString m_name;

88 AtomicString m_csp;	87 AtomicString m_csp;

89 bool m_didLoadNonEmptyDocument;	88 bool m_didLoadNonEmptyDocument;

90 bool m_allowFullscreen;	89 bool m_allowFullscreen;

91 bool m_allowPaymentRequest;	90 bool m_allowPaymentRequest;

92 Member<HTMLIFrameElementSandbox> m_sandbox;	91 Member<HTMLIFrameElementSandbox> m_sandbox;

93 Member<HTMLIFrameElementPermissions> m_permissions;	92 Member<HTMLIFrameElementPermissions> m_permissions;

94	93

95 WebVector<WebPermissionType> m_delegatedPermissions;	94 WebVector<WebPermissionType> m_delegatedPermissions;

96	95

97 ReferrerPolicy m_referrerPolicy;	96 ReferrerPolicy m_referrerPolicy;

98 };	97 };

99	98

100 } // namespace blink	99 } // namespace blink

101	100

102 #endif // HTMLIFrameElement_h	101 #endif // HTMLIFrameElement_h

OLD	NEW